Giter Site home page Giter Site logo

Comments (4)

ryanlarrabure avatar ryanlarrabure commented on August 24, 2024

We should consider logging the exception instead of printing it. It will make debugging and testing easier.

from ginkgo.

progrium avatar progrium commented on August 24, 2024

Alan suggests we have two options: swallowing it or aborting (just die). Service.stop() should not raise. If it did, it's the Service implementor's fault.

from ginkgo.

progrium avatar progrium commented on August 24, 2024

Okay, we know that Service.stop() should not call Service.do_stop() if the service is not started, but should call stop() on its children.

We also decided to remove the try...except inside start() (and serve_forever()) that will try to call stop() on an exception.

from ginkgo.

progrium avatar progrium commented on August 24, 2024

I think the latest master satisfies this. I remember this was a nebulous issue that got into a bunch of other issues... most of which seem to have been resolved after 0.5.0

from ginkgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.