Giter Site home page Giter Site logo

Comments (4)

bzbarsky-apple avatar bzbarsky-apple commented on September 26, 2024

You can detect the vendor ID of the commissioner. It's right there in the AddNOC command.

But this approach breaks completely as soon as a device is commissioned by two different commissioners, no? You can't have different PartsList on different simultaneous fabrics; that's a spec violation.

from connectedhomeip.

jvmahon avatar jvmahon commented on September 26, 2024

But this approach breaks completely as soon as a device is commissioned by two different commissioners, no? You can't have different PartsList on different simultaneous fabrics; that's a spec violation.

Yes, this is what I wanted to do. Since you are saying that is a spec violation, I guess the issue to be considered is whether this should be a spec violation, or if it should be permissible.

At present, it seems that the way Matter controllers are progressing, it is unlikely that all controllers will support all the endpoint types and features. So, either device makers have to program for the "least capable common set" or have devices that don't behave right on certain fabrics / controllers..

In an ideal world, controller certification would be "tougher" and require controllers to all implement at least a base set of features like Mode Select, OTA, Generic Switch. I doubt that will happen.

So, there is a problem for the technology and manufacturers - either (a) they have to limit capabilities to make the device work on the range of controllers consumers use, or (b) there needs to be some way to customize endpoints based on the vendor ID, or you end up with devices that create user interface problems (as is the issue being dealt with here for Google Home and the Generic Switch type).

So, the request is (i) consider allowing different PartsList depending on fabric, and (ii) add functionality to allow this to be programmed in a device (probably more on an "exception" basis -- i.e, always give full PartsList except if XXX).

from connectedhomeip.

jvmahon avatar jvmahon commented on September 26, 2024

I assume this is a "long shot" to get a change here, but I'm asking anyway due to the practical issue this solves (and for which there isn't really another solution that is apparent).

Thanks for considering this!

from connectedhomeip.

bzbarsky-apple avatar bzbarsky-apple commented on September 26, 2024

So a few things:

  1. This isn't the right venue for spec change proposals; those need to happen in the CSA working group.
  2. Consider what happens if devices hardcode these sorts of vendor checks and then controllers (which update a lot more often than devices) are changed to handle the situation better... but those devices continue to not work as well as they could with those controllers.
  3. In general, it's hard for certification to test what UI looks like because the spec generally can't require anything about UIs... those are really context-dependent.

Speaking of item 2: I assume you've reported the relevant issues to the controllers that are not doing the "right thing" here?

from connectedhomeip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.