Giter Site home page Giter Site logo

[BUG] Subscriptions for Matter devices for user is unnecessarily delayed until next scheduled resub retry in some cases about connectedhomeip HOT 5 OPEN

ndyck14 avatar ndyck14 commented on May 27, 2024
[BUG] Subscriptions for Matter devices for user is unnecessarily delayed until next scheduled resub retry in some cases

from connectedhomeip.

Comments (5)

bzbarsky-apple avatar bzbarsky-apple commented on May 27, 2024 1

We should consider triggering resubscribe on both CASE establishment (using the new session, not creating a new one), and on any IM message received, not just ReportData.

from connectedhomeip.

bzbarsky-apple avatar bzbarsky-apple commented on May 27, 2024

In particular, we only retrigger subscription on receiving a ReportData, not on CASE establishment from the other side or the other side sending any other IM message.

@jtung-apple

from connectedhomeip.

jtung-apple avatar jtung-apple commented on May 27, 2024

I'm taking a look but my first thought is that currently the logic for re-subscription is only triggered when the IME gets called on OnUnsolicitedReportData. I could look into the changes needed to have CASE establishment plumb through to trigger re-subscribe and we can discuss if that's what's needed here.

@ndyck14 Do you happen to be able to readily reproduce this? If so could you upload logs from both devices?

I'm wondering if there's something else wrong / a bug that's causing this, that should be fixed first.

from connectedhomeip.

ndyck14 avatar ndyck14 commented on May 27, 2024

Power cycle HPM (unclear if strict precondition)

I did this with the intent of clearing CASE resume contexts (guesswork) so as to test worst case. Basically my brief mental model of resume sub is its a best effort by device. Otherwise CASE is re-established because we're looking for OTA i think.

I can try to reproduce, but is there evidence to suggest that this onus should not be on the subscriber to ensure its done as swiftly as possible? I guess in case the sub is already active, we don't want to double up? Is doubling up even possible?

from connectedhomeip.

ndyck14 avatar ndyck14 commented on May 27, 2024

note that my test steps were in done directed after already observing this previously without logs installed, so I've seen this happen multiple times. I've also been tracking CASEs (pun intended) for a year or more where things take too long to reconnect (eg #25091, which Boris reported on my behalf )

from connectedhomeip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.