"when" is the problem

[project-imas]

"when" is the problem

[gavin-black]

Is this every time you try to create a persistent store, or some snippet of code that is causing it? Sorry a little confused how to reproduce this.

[sxua]

@gblackMitre to reproduce this, you just need to create an attribute when in random entity and voila.
The reason is - non-escaped attributes, for example, if we have an entity with this attribute, create table query will fail, because WHEN is SQLite's keyword:

CREATE TABLE SomeEntity (id integer primary key, _entityType integer, when, what, where);

This issue can be resolved by adding single quotes around each attribute on query generation stage. If you think it would be ok, I can make a pull request for this.

[gavin-black]

Thanks, was able to reproduce it now.

[gavin-black]

For my own reference:
columnNamesForEntity grabs the attributes into a list of key values. Need to go through and prepend something unique to each key. This may not be the only place, but any other area impacted will have a similar fix.

[sxua]

@gblackMitre sxua@63fdf29

[gavin-black]

@sxua Thank you for the fix, I've added it in commit 12e5b3c