Comments (9)
Nice catch!
I don't like that rsync step anyway. Yet another reason to refactor it. Although if packaging runs, you're not running rsync. 🤔
One question though: How come you have a cdk.out directory in a construct library?
from projen.
I think this is a simple as adding cdk.out
to .gitignore
and .npmignore
for the awscdk-construct
project.
from projen.
Just need to add a line like this
projen/src/cdk/jsii-project.ts
Line 421 in e46da7e
awscdk-construct
project here: projen/src/awscdk/awscdk-construct.ts
Line 80 in e46da7e
Let me know and I can prep a PR to do that.
from projen.
I've looked into this more. Long story short, anyone running integ tests should either
- use the built-in integration test feature, or
- use the experimental integ-runner feature, or
- use the CdkConfig component to configure the config for the integ test.
All three of these options already prevent this issue from happening. In particular CdkConfig
adds the configured cdk out dir to .gitignore
.
For anyone choosing a custom implementation (which is reasonable choice) it will be on them to ensure the implementation is complete. Given that we already have 3 viable options for this, I'm not keen to speculatively support custom implementations.
from projen.
The cdk.out dir must be coming from testing. To test the construct I'm building, I run this command in the root dir:
npx cdk deploy --app lib/my-construct/integ.default.js
where the integ.default.js file contains the CDK code that references the construct I'm building.
Here's an example of such a file: integ.default.ts
from projen.
Adding cdk.out
to .npmignore
(via .projenrc.ts
) worked for me!
Thanks!
from projen.
Would love a PR for this 😉
from projen.
Yes that should be it. Run the build locally to update the snapshots and you are good to go!
from projen.
Thanks for the update. Apologies for dropping the ball on this one.
from projen.
Related Issues (20)
- github issue template
- Publishing v0.81.11 to PyPI failed HOT 1
- Generated source code for LambdaFunction where `edgeLambda: true` is incorrect HOT 3
- Release tags wrong commit HOT 1
- !reference tag in gitlab job scripts will be rendered in quotes
- typeRoots is missing in TypescriptConfigOptions
- moduleDetection is missing in TypescriptConfigOptions
- Getting Started on home page is broken HOT 1
- setfacl is not pre-installed on CodeBuild images HOT 2
- No validation done on name except duplicate checking
- Add `projenrc` dir to Jest test match list
- feat(tsconfig): removeInclude/Exclude
- bug(typescript): By default, TypeScriptProject (and derivatives) compile and publish test files in `src`
- Setting projenVersion attempts to pull projen from private npm registry HOT 3
- Mismatching version for `@aws-solutions-constructs` HOT 4
- Licenses applied wrong HOT 1
- PythonProject calls `installDependencies` indiscriminately HOT 1
- [BUG] (Maven plugin executions synthesized incorrectly)
- [FEATURE] (allow sorting of pom.xml plugins for maven) HOT 1
- [FEATURE] Maven: Allow defining configuration values at the plugin execution level HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from projen.