Comments (6)
Cool idea. Someone may want to play with these in a PR: https://github.com/marketplace?type=actions&query=markdownlint I would recommend a separate GitHub Actions workflow for this.
from helm-charts.
I agree pre-commit hook approach has the downside of burdening each new user with every previous problem. I find that better for internal teams than projects where we want to encourage many contributors.
superlinter looks pretty cool! Calls https://github.com/igorshubovych/markdownlint-cli#readme which calls https://github.com/DavidAnson/markdownlint anywayโฆย nice ๐ I leave it to the maintainers to decide, but I see nothing wrong in this approach personally from a charts repo CI perspective.
from helm-charts.
Sounds like someone wants to write a GH Action ๐ (I can relate! They're super-fun)
One note: @Xtigyro mentioned the markdownlint
vscode plugin for local work: https://github.com/DavidAnson/vscode-markdownlint (can also be run apart from vscode https://github.com/DavidAnson/markdownlint).
from helm-charts.
I added two draft PRs to demonstrate two different approaches. One is using pre-commit and the other one super-linter.
No matter for which we decide we should fix lint errors on all files to improve contributor experience. For example super-linter just checks modified files, which is the reason why everything is ok. It would be bad if we force the first contributor modifying a file to fix all linting errors.
PS: Sorry for the not so well created PRs. It's just terrible trying to author something on a mobile :-)
from helm-charts.
Yeah - I think that's fine. I like superlinter!
I'm also not in favour of pre-commit hooks - my arguments are exactly the same as stated by @scottrigby above.
from helm-charts.
Would be nice if one could execute the same linter locally. I personally like https://pre-commit.com/ as it allows to lint only modified files.
from helm-charts.
Related Issues (20)
- [kube-prometheus-stack] grafana okta sso setup
- [Prometheus-adapter] Does Prometheus-adapter support scraping custom metrics for windows pods to implement HPA.
- [kube-prometheus-stack] How to set kube-prometheus-stack Grafana sidecar containers resource limit? HOT 4
- [prometheus-stackdriver-exporter] Deployment metadata missing annotations
- [kube-state-metrics] DaemonSet option missing
- [kube-prometheus-stack] unknown field "automountServiceAccountToken" HOT 1
- [kube-prometheus-stack] override image repository from helm command line (--set) not working HOT 2
- [kube-prometheus-stack] no specific registry key of .Values.prometheusOperator.admissionWebhooks or .patch is respected if global.registry is set
- [prometheus-elasticsearch-exporter] image.pullSecret not taken into account HOT 2
- [kube-prometheus-stack] Networking NO DATA HOT 4
- [prometheus-windows-exporter] Readiness probe always returning 404 HOT 1
- [prometheus] How to set podLabels for the remaining pods (alertmanager, node-exporter, pushgateway, etc.) HOT 1
- [kube-prometheus-stack] Wrong Grafana default E-Mail
- [kube-prometheus-stack] retentionSize is not taken into effect HOT 1
- [prometheus-kube-stack] gcfsd filesystem has less than 5% space left
- [kube-prometheus-stack] Node Exporter Job name changed after upgrade fro 61.2.0 to 62.1.0 HOT 4
- [kube-prometheus-stack] Issue with Metric to fetch k8's cluster nodes memory usage HOT 1
- [kube-prometheus-stack] Issue with the Prometheus upgrade from 61.8.0 to 62.2.1 HOT 4
- [kube-prometheus-stack] grafana won't display node-exporter metrics on minikube HOT 1
- [kube-prometheus-stack] Missing flexibility support for single/multi cluster alert from kubernetes-mixin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-charts.