Giter Site home page Giter Site logo

Comments (10)

DavidAnson avatar DavidAnson commented on August 28, 2024 5

@JoshuaKGoldberg Maybe add the markdownlint-rule keyword to your package so it shows up here for other people to find: https://www.npmjs.com/search?q=keywords:markdownlint-rule

@JoshuaKGoldberg You may be able to use the markdownlint-rule-helpers package to remove the dependency of your rule on internals of the linter: https://www.npmjs.com/package/markdownlint-rule-helpers

@JoshuaKGoldberg I added a note to the issue above to address one of the concerns therein.

Everyone: The .markdownlint.json configuration file is exclusively for configuring rules, so that doesn't help the scenario above. However, I created an alternate version of the CLI that is entirely configuration-file-based. This scenario where it's not convenient to update the caller of the tool is sort of kind of what I had in mind when I created it. Perhaps that could help: https://github.com/DavidAnson/markdownlint-cli2

Everyone: you may also be interested in this issue with a somewhat more detailed discussion of line breaking: DavidAnson/markdownlint#298

from helm-charts.

JoshuaKGoldberg avatar JoshuaKGoldberg commented on August 28, 2024 4

It would be an honor to have my teeny markdownlint rule used here ☺️ and I would be happy to support as needed!

from helm-charts.

torstenwalter avatar torstenwalter commented on August 28, 2024 1

@scottrigby nice references! I like the article linked from denver.org https://rhodesmill.org/brandon/2012/one-sentence-per-line/

I agree that semantic line breaks / one sentence per line makes it easier to review changes.
I have no experience with linters to enforce it.
A good start would be to disable rules which force line breaks after 80 characters when linting markdown.

from helm-charts.

gkarthiks avatar gkarthiks commented on August 28, 2024 1

@scottrigby I like the semantics breaks. It's also easy on eyes, doesn't need to read a statement twice to make sense of.

Here's my +1 on this.

from helm-charts.

monotek avatar monotek commented on August 28, 2024 1

Could we add this as a requirement to the ci pipeline / linter maybe?
If so, sounds good to me :)

from helm-charts.

torstenwalter avatar torstenwalter commented on August 28, 2024 1

It would be an honor to have my teeny markdownlint rule used here and I would be happy to support as needed!

@JoshuaKGoldberg Do you know if it's possible to in include your rule in https://github.com/github/super-linter?

Markdownlint is called here: https://github.com/github/super-linter/blob/c58bab262756890004e5bbb3cf8744ed1e6174c4/lib/linter.sh#L1646

from helm-charts.

JoshuaKGoldberg avatar JoshuaKGoldberg commented on August 28, 2024 1

πŸ˜• no, it looks like it's not possible to include custom -r/--rules markdownlint rules in super-linter right now. I'll defer to @DavidAnson as to whether there's any interest in allowing those rules to be configured via the config file.

Alternately, maybe super-linter could take an issue to allow configuring those things? I haven't used it enough to know their project ethos very well.

from helm-charts.

scottrigby avatar scottrigby commented on August 28, 2024

@JoshuaKGoldberg pointed me here JoshuaKGoldberg/sentences-per-line#6 and said it should be doable, the rule is basically a glorified regular expression

from helm-charts.

stale avatar stale commented on August 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

from helm-charts.

stale avatar stale commented on August 28, 2024

This issue is being automatically closed due to inactivity.

from helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.