Comments (4)
@mmozuras Was this fixed? I seem to get this issue sometimes. I run the master version from github.
from pronto.
@Linuus I considered it fixed, but it was reproduced in another way today. Reopening again and will try to figure it out.
from pronto.
Got the same issue today. But pronto messes positions even without pr changes at all, just comments on the wrong lines.
Fixed by changing line.position
to message.line.position
https://github.com/mmozuras/pronto/blob/master/lib/pronto/formatter/github_pull_request_formatter.rb#L21
but don't think that this is a proper fix
from pronto.
PRs from @jhass fix this. Currently unreleased
in master
.
from pronto.
Related Issues (20)
- Request to move pronto-slim_lint runner repository into prontolabs HOT 2
- Validation failed 422 when pronto tries to comment on a Pull Request - pull_request_review_thread.diff_hunk HOT 1
- Problem with version 4.22 of octokit HOT 1
- Release new gem version HOT 2
- Pronto doesn't seem to compare files if they only changed file mode
- Relax Octokit version dependency HOT 1
- Could not find rake-13.0.1 in any of the sources (Bundler::GemNotFound)
- Upgrade rugged dependency for Ruby 3.2.0 - Dir.exists? is deprecated HOT 6
- config value 'safe.directory' was not found (Rugged::ConfigError) error after upgrade to 0.11.1 HOT 8
- merge_base: revspec 'master' not found (Rugged::ReferenceError) HOT 2
- Pronto restricting version of `chardet`
- Issue with comments not being created/posted with Github action workflow HOT 1
- Dotfiles are being ignored
- Metrics / analytics
- Handling comments that have been resolved HOT 1
- Rugged 1.7.1 breaks gem HOT 20
- undefined method `[]' for nil:NilClass HOT 2
- Refactoring the way formatters are loaded to make easy to include custom formatter HOT 5
- Allow Octokit 8.0
- Failed to setup in GitLab CI HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pronto.