Giter Site home page Giter Site logo

Comments (4)

Linuus avatar Linuus commented on August 25, 2024

@mmozuras Was this fixed? I seem to get this issue sometimes. I run the master version from github.

from pronto.

mmozuras avatar mmozuras commented on August 25, 2024

@Linuus I considered it fixed, but it was reproduced in another way today. Reopening again and will try to figure it out.

from pronto.

somebody32 avatar somebody32 commented on August 25, 2024

Got the same issue today. But pronto messes positions even without pr changes at all, just comments on the wrong lines.

Fixed by changing line.position to message.line.position https://github.com/mmozuras/pronto/blob/master/lib/pronto/formatter/github_pull_request_formatter.rb#L21

but don't think that this is a proper fix

from pronto.

mmozuras avatar mmozuras commented on August 25, 2024

PRs from @jhass fix this. Currently unreleased in master.

from pronto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.