pronto-brakeman & pronto-rails_best_practices run order inconsistencies

[prontolabs]

pronto-brakeman & pronto-rails_best_practices run order inconsistencies

[eliotsykes]

I've edited the above issue report to correct information on false positives and missing issues. The issue continues to be valid, particularly the Sexp monkey patch conflicts.

[nbekirov]

Hey @eliotsykes!

I'm not sure that the Sexp monkey-patching explains the entire issue yet

My investigation is definitely pointing in the same direction as Sexp is so ubiquitous in brakeman, ruby_parser, code_analyzer.

I've made a repository with an executable test case demonstrating the issue in isolation from pronto and other gems. I hope that it'll be useful for anyone willing to tag along.

It includes:

• Failing example
• Possible solution - after a bit of tinkering and reading, forking seems to be the the best (only?) possible effective way to sandbox some code execution in Ruby. I've used Yehuda Katz's solution here.

Please check it out. I'm positive we'll come up with a solution very soon. 😃

[eliotsykes]

Hi @nbekirov - thanks for looking into this. Your forking plan looks promising.