Giter Site home page Giter Site logo

Comments (2)

imlk0 avatar imlk0 commented on May 27, 2024 1

Fixed in commit 740fe4d

from proot-rs.

imlk0 avatar imlk0 commented on May 27, 2024

Document the steps to solve this problem:

This is a bug caused by a strange behavior of the standard library of Rust:

  • The struct std::path::PathBuf in rust std is used to represent a path.

  • If a PathBuf contains no trailing slash, call .push("") on it will cause a trailing slash being appended to the end. playground

    use std::path::PathBuf;
    
    fn main() {
        let mut path = PathBuf::from("foo/bar");
        dbg!(&path); // "foo/bar"
        path.push("");
        dbg!(&path); // "foo/bar/"
    }
  • std::path::PathBuf is not sensitive to a trailing slash in path, but some Linux syscall are sensitive to the slash at the end of the path. They assume a path with a trailing slash as a directory. playground

    use std::path::PathBuf;
    
    fn main() {
        let path1 = PathBuf::from("foo/bar");
        let path2 = PathBuf::from("foo/bar/");
        
        assert_eq!(path1, path2); // ok
        assert_ne!(path1.as_os_str(), path2.as_os_str()); // ok
    }
  • In our test case /etc/passwd is a regular file, But proot-rs passes a /etc/passwd/ to the system call, which is the cause of ENOTDIR

from proot-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.