Giter Site home page Giter Site logo

Comments (9)

Stebalien avatar Stebalien commented on July 17, 2024 1

Sure. I'll take a stab at it.

from .github.

marten-seemann avatar marten-seemann commented on July 17, 2024

https://github.com/protocol/.github/blob/master/.github/workflows/stale-repos.yml should catch those. Doesn't it?

from .github.

mvdan avatar mvdan commented on July 17, 2024

The typo fix was less than an hour after the line was added, but the check runs every 6h. I assume we can't run it more often without starting to run into rate limits. I'd say this is working as intended - we would have caught the typo within hours.

from .github.

marten-seemann avatar marten-seemann commented on July 17, 2024

The typo fix was less than an hour after the line was added, but the check runs every 6h. I assume we can't run it more often without starting to run into rate limits.

We could run it a lot more often, this job just takes 30s, so there's no risk of being rate-limited here, even if we ran it every 30 min or so (I assume).

I'd say this is working as intended - we would have caught the typo within hours.

We should probably run this job on pull_request too (or only?), that would've caught the problem immediately.

from .github.

mvdan avatar mvdan commented on July 17, 2024

SGTM, we don't have that many PRs anyway.

from .github.

Stebalien avatar Stebalien commented on July 17, 2024

Running on PR is what I'm looking for. But can we just check changed lines? I.e., diff the json files and check any added repos?

from .github.

marten-seemann avatar marten-seemann commented on July 17, 2024

Right, we still need to run it as a cron, as repos might be deleted at any time.

But can we just check changed lines? I.e., diff the json files and check any added repos?

That should be possible, but it might be a bit tricky to parse the diff between two JSON versions.

from .github.

Stebalien avatar Stebalien commented on July 17, 2024

Eh, I'd parse the json first, then use something like comm to compare.

from .github.

marten-seemann avatar marten-seemann commented on July 17, 2024

TIL: comm :) That definitely makes more sense.

Would you mind updating the workflow?

from .github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.