Comments (9)
Sure. I'll take a stab at it.
from .github.
https://github.com/protocol/.github/blob/master/.github/workflows/stale-repos.yml should catch those. Doesn't it?
from .github.
The typo fix was less than an hour after the line was added, but the check runs every 6h. I assume we can't run it more often without starting to run into rate limits. I'd say this is working as intended - we would have caught the typo within hours.
from .github.
The typo fix was less than an hour after the line was added, but the check runs every 6h. I assume we can't run it more often without starting to run into rate limits.
We could run it a lot more often, this job just takes 30s, so there's no risk of being rate-limited here, even if we ran it every 30 min or so (I assume).
I'd say this is working as intended - we would have caught the typo within hours.
We should probably run this job on pull_request
too (or only?), that would've caught the problem immediately.
from .github.
SGTM, we don't have that many PRs anyway.
from .github.
Running on PR is what I'm looking for. But can we just check changed lines? I.e., diff the json files and check any added repos?
from .github.
Right, we still need to run it as a cron, as repos might be deleted at any time.
But can we just check changed lines? I.e., diff the json files and check any added repos?
That should be possible, but it might be a bit tricky to parse the diff between two JSON versions.
from .github.
Eh, I'd parse the json first, then use something like comm
to compare.
from .github.
TIL: comm
:) That definitely makes more sense.
Would you mind updating the workflow?
from .github.
Related Issues (20)
- Add github action for nightly build HOT 2
- Support protected branches for the js release flow
- can't use GitHub secrets in repo-specific setup HOT 3
- uCI Release: Go v1.20.0 HOT 13
- Go test -cover breaks certain tests HOT 3
- Cache go modules and build cache HOT 2
- Better go linters HOT 2
- default + required in reusable workflow seems to be broken HOT 5
- Automerge might starve other workflows HOT 1
- Unified CI config update job broken on all js repos HOT 1
- draft release notes not updated on force push HOT 1
- patch release incorrectly cut on master, not on release branch
- Commit messages in auto-merged PRs do not follow conventional commits HOT 1
- Disable codecov annotations on PRs HOT 2
- Release Check workflow not comparing the correct versions for Golang RCs
- Thoughts about the future of Unified CI HOT 3
- Find stale repositories should also error on inaccessible repos HOT 1
- Releaser workflow marks latest releases incorrectly
- Configure workflows triggered on pull_request to run on base change HOT 1
- proposal: better go test outputs HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from .github.