Cutting releases on a release branch

[protocol]

Cutting releases on a release branch

[marten-seemann]

Turns out there's an Action for that: https://github.com/actions-ecosystem/action-get-merged-pull-request.

We can distinguish between a normal push and a push that resulted from a PR being merged by looking at the output of this action, for example by checking if output.title == '':

 - uses: actions-ecosystem/action-get-merged-pull-request@v1
   id: getmergedpr
   with:
      github_token: ${{ secrets.GITHUB_TOKEN }}
- run: <do stuff if a PR was merged>
  if: steps.getmergedpr.outputs.title != ''

This works for PR resulting from a merge commit and also for a squash merge (probably also for a rebase merge, but I haven't checked that).

[mvdan]

As an idea, you could limit it to branches named main, master, and release-.*.

[marten-seemann]

release-.* is dangerous. I have created branches named release-v0.4.0 (as a PR to master) before.

release-branch-.* or off-master-release-.* might be less prone to accidental releases.

[marten-seemann]

I really wish there was a way to get the PR when push is run (if the push event was triggered by a PR merge).
Then we could for example introduce a release label: Only if this label is set on the PR, will a merge to a branch (other than master) trigger a release.

[marten-seemann]

Fixed by #230.