Comments (4)
I don't understand what you mean by "install dependencies". Like you say, commands like go test
will already download whatever modules are needed and not yet in the cache.
So yeah, I would just remove this step. You could do a go mod download
, but it's unnecessary, and it might also actually slow down CI. A go test ./...
can be more clever and start testing some packages while others are still downloading dependencies, for example. Or maybe it doesn't actually need to download all indirectly required modules.
from .github.
I don't understand what you mean by "install dependencies". Like you say, commands like go test will already download whatever modules are needed and not yet in the cache.
The idea was to make the execution time of each step meaningful, but that would require go test
to not download any dependencies. Maybe this shouldn't have been a goal to begin with though.
from .github.
If you don't want the downloading to generally be part of the runtime of the tests, you could always use caching :)
from .github.
The go install
step was removed in #8.
from .github.
Related Issues (20)
- Add github action for nightly build HOT 2
- Support protected branches for the js release flow
- can't use GitHub secrets in repo-specific setup HOT 3
- uCI Release: Go v1.20.0 HOT 13
- Go test -cover breaks certain tests HOT 3
- Cache go modules and build cache HOT 2
- Better go linters HOT 2
- default + required in reusable workflow seems to be broken HOT 5
- Automerge might starve other workflows HOT 1
- Unified CI config update job broken on all js repos HOT 1
- draft release notes not updated on force push HOT 1
- patch release incorrectly cut on master, not on release branch
- Commit messages in auto-merged PRs do not follow conventional commits HOT 1
- Disable codecov annotations on PRs HOT 2
- Release Check workflow not comparing the correct versions for Golang RCs
- Thoughts about the future of Unified CI HOT 3
- Find stale repositories should also error on inaccessible repos HOT 1
- Releaser workflow marks latest releases incorrectly
- Configure workflows triggered on pull_request to run on base change HOT 1
- proposal: better go test outputs HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from .github.