Giter Site home page Giter Site logo

Comments (12)

kevindherman avatar kevindherman commented on August 16, 2024 1

@curtismchale all sounds better.

from wp-proudcity.

kevindherman avatar kevindherman commented on August 16, 2024

@curtismchale additional widgets that use images and should have alt text requirements:

  • Hero unit (all displays except simple heading)
  • Gallery

from wp-proudcity.

kevindherman avatar kevindherman commented on August 16, 2024

All of these files come from the media library so my hope is that if we start with forcing alt text to be required when uploading the original, then alt text is addressed in all applications of the file.

from wp-proudcity.

curtismchale avatar curtismchale commented on August 16, 2024

@kevindherman we can force ALT text in the media gallery when someone selects an image with the Fix ALT Text plugin.

This doesn't handle the ALT text in widgets as it won't fill in the text when you add an image but it will stop anyone from picking an image without ALT text so it would force older images to get the text and any new image would get it as well.

I'll have to build something custom to work with SiteOrigin widgets. Should I do that or stop here for now?

from wp-proudcity.

kevindherman avatar kevindherman commented on August 16, 2024

@curtismchale can this at least be deployed to Petaluma?

I think getting this part on Petaluma would be a nice win then circle back for the rest with breathing room.

from wp-proudcity.

curtismchale avatar curtismchale commented on August 16, 2024

@kevindherman is there a reason we wouldn't deploy it to all sites?

from wp-proudcity.

kevindherman avatar kevindherman commented on August 16, 2024

@curtismchale @lukefretwell the plugin looks great and is definitely an improvement from what we had before.

I really like the reporting/fixing feature to help solve the problem.

from wp-proudcity.

curtismchale avatar curtismchale commented on August 16, 2024

@kevindherman it's on Beta now and getting ready to go to all sites.

from wp-proudcity.

kevindherman avatar kevindherman commented on August 16, 2024

@curtismchale this is great and I actually think this does everything we need.

  1. I added media in visual editor grabbing image file that was already uploaded and had no alt text, it required me to add it
  2. I added an image set and did the same as above
  3. I uploaded a new image for the image set and needed to add the alt text
  4. I added an image widget with the same experience.

I'm not sure the widget level alt text is needed but we can revisit.

It may be part of a followup but the plugin's reporting/fixing is really nice and could go under tools in our admin. I didn't see where to access and play around with those features so lets not have that hold this up.

Huge improvement as is. @lukefretwell

from wp-proudcity.

curtismchale avatar curtismchale commented on August 16, 2024

@kevindherman yeah the settings UI is only available to PC Admins, but it doesn't match well with our Admin theme at all and would require a bunch of work to make it accessible to customers.

from wp-proudcity.

kevindherman avatar kevindherman commented on August 16, 2024

makes sense. for another day then.

from wp-proudcity.

curtismchale avatar curtismchale commented on August 16, 2024

Deployed the plugin

Composer: https://github.com/proudcity/wp-proudcity/releases/tag/2024.05.07.1214
Build: https://github.com/proudcity/proud-recipes/releases/tag/2024.05.07.1214

from wp-proudcity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.