WasmData::pairs() unstable

[proxy-wasm]

WasmData::pairs() unstable

[bianpengyuan]

well, this is expected behavior IMO. Caller has to take ownership of the the header map, since it returns a unique_ptr.

[esnible]

It fooled me for a couple of hours. At a minimum, put a comment on proxy_wasm_api.h:99 for std::vector<std::pair<std::string_view, std::string_view>> pairs(); saying that the resulting vector will not be valid past the lifetime of the WasmData.

Consider having two different variants of pairs(), one that produces a deep copy the caller must free, and another that is very fast.

[bianpengyuan]

It fooled me for a couple of hours. At a minimum, put a comment on proxy_wasm_api.h:99 for std::vector<std::pair<std::string_view, std::string_view>> pairs(); saying that the resulting vector will not be valid past the lifetime of the WasmData.

I think it speaks for itself since it is string_view, but yeah, I guess we can make it more clear.

Consider having two different variants of pairs(), one that produces a deep copy the caller must free, and another that is very fast.

I don't think that would be ideal, this is going to cause performance problem and not a good practice, we should avoid that in the API.