Giter Site home page Giter Site logo

Comments (6)

brunokrebs avatar brunokrebs commented on August 26, 2024

Well, actually I've found a better solution, which is the same one implemented by CKEditor to the issue opened there. Check out the following merge on their repo.

I will make a pull request with my solution.

from ngwysiwyg.

psergus avatar psergus commented on August 26, 2024

@brunokrebs, thanks for much for helping man 👍

from ngwysiwyg.

brunokrebs avatar brunokrebs commented on August 26, 2024

@psergus would you mind to release a patch with my fix?

from ngwysiwyg.

psergus avatar psergus commented on August 26, 2024

@brunokrebs, yeah, should be already in the master repo. Please check it out. Let me know if something not right.

from ngwysiwyg.

brunokrebs avatar brunokrebs commented on August 26, 2024

You are right, @psergus, my fix is in the master repo already, but there is no new patch (i.e. no git tag) with my fix.

I was going to tell you that you need to bump it with bower, but I just saw that bower.json has the wrong version. I'm going to fix it and send a pull request.

from ngwysiwyg.

psergus avatar psergus commented on August 26, 2024

ahh, you are 100% right. Yea, sends the request and I will merge with the
master.

On Sun, Jan 10, 2016 at 10:08 AM, Bruno Krebs [email protected]
wrote:

You are right, @psergus https://github.com/psergus, my fix is in the
master repo already, but there is no new patch (i.e. no git tag) with my
fix.

I was going to tell you that you need to bump it with bower, but I just
saw that bower.json
https://github.com/psergus/ngWYSIWYG/blob/master/bower.json#L3 has the
wrong version. I'm going to fix it and send a pull request.


Reply to this email directly or view it on GitHub
#22 (comment).

Best regards,
Sergey Petrenko

from ngwysiwyg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.