Rate Limiter issues

[pseudonym117]

Rate Limiter issues

[pseudonym117]

one limitation of the current rate limiter that i know of is that pending requests are not checked before a request is made. if 25 requests are made at the same time with a limit of 20 request, 5 should currently get a 429.

That comment is specifically talking about when the rate limit resets. Assume you have the limit of 10 calls/min. If you make a 2 requests right as the rate limit is about to reset, request A and request B. Response A is sent back with the header saying 10 requests have been made (so the next call will be limited). Response B is sent back with a header saying that 1 request has been made (the rate limit has reset). If response B is processed before response A, then what will happen is that the count will be set to 1, and then set to 10, leading all subsequent calls to be rate limited for a minute.

I believe that 2nd case is not a very likely case, but i believe it is possible, which is why that comment exists.

regarding the issue writing to the tuple, that seems like a pretty clear bug and should be easy to solve.

Can you split this into 2 separate issues? one for the clear bug writing things that are not writable, and one for the fact that pending requests are not tracked?