Giter Site home page Giter Site logo

Comments (9)

halloleo avatar halloleo commented on May 24, 2024 1

Thanks for the tip in the follow up, @gangelop! I just start using prosopopee and this bug annoyed me too. The new baguetteBox fixes it for me as well.

from prosopopee.

gangelop avatar gangelop commented on May 24, 2024

This issue is resolved by updating to https://github.com/feimosi/baguetteBox.js/releases/tag/v1.11.1

from prosopopee.

gangelop avatar gangelop commented on May 24, 2024

@halloleo I'm so happy this is solved! \o/

@Psycojoker I'm not sending a PR for this one because it would be the same amount of work for you to compare the minified js to my PR for review compared to doing it yourself. So this is a gentle reminder for an easy fix of updating baguetteBox to v.11.1 to fix this issue.

Thanks for reviewing and merging all my other PRs. Have a nice week.

from prosopopee.

Psycojoker avatar Psycojoker commented on May 24, 2024

@gangelop that's done and I've release a 1.1.1 with it :) (and a 1.1 yesterday)

from prosopopee.

Psycojoker avatar Psycojoker commented on May 24, 2024

Closing therefor, don't hesitate to reopen if needed

from prosopopee.

halloleo avatar halloleo commented on May 24, 2024

Hi have just tried the newest release 1.1.1 from pypi, but it does not seem to incoroprate a new baguetteBox.js:

The baguetteBox.min.css files are different too.

from prosopopee.

Psycojoker avatar Psycojoker commented on May 24, 2024

That's really weird because this is not what the commit is saying:

image

I might have made a mistake using twine when uploading the package (second time I'm using it)

from prosopopee.

Psycojoker avatar Psycojoker commented on May 24, 2024

So, turns out, setup.py has bad caching for wheel generation in the "build/" folder which doesn't detect file differences for some reason (but only for the wheel, the tar.gz archive is correct), I've made a new release with the correct files, thx for repporting this bug :)

from prosopopee.

halloleo avatar halloleo commented on May 24, 2024

I have installed the latest release fro pypi (prosopopee 1.1.2) and baguetteBox works now correctly.

Thanks heaps for fixing this, @Psycojoker!

from prosopopee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.