Comments (9)
Thanks for the tip in the follow up, @gangelop! I just start using prosopopee and this bug annoyed me too. The new baguetteBox fixes it for me as well.
from prosopopee.
This issue is resolved by updating to https://github.com/feimosi/baguetteBox.js/releases/tag/v1.11.1
from prosopopee.
@halloleo I'm so happy this is solved! \o/
@Psycojoker I'm not sending a PR for this one because it would be the same amount of work for you to compare the minified js to my PR for review compared to doing it yourself. So this is a gentle reminder for an easy fix of updating baguetteBox
to v.11.1
to fix this issue.
Thanks for reviewing and merging all my other PRs. Have a nice week.
from prosopopee.
@gangelop that's done and I've release a 1.1.1 with it :) (and a 1.1 yesterday)
from prosopopee.
Closing therefor, don't hesitate to reopen if needed
from prosopopee.
Hi have just tried the newest release 1.1.1 from pypi, but it does not seem to incoroprate a new baguetteBox.js:
baguetteBox.min.js
in Prosopopee has version 1.11.0baguetteBox.min.js
from https://github.com/feimosi/baguetteBox.js has version 1.11.1
The baguetteBox.min.css
files are different too.
from prosopopee.
That's really weird because this is not what the commit is saying:
I might have made a mistake using twine when uploading the package (second time I'm using it)
from prosopopee.
So, turns out, setup.py has bad caching for wheel generation in the "build/" folder which doesn't detect file differences for some reason (but only for the wheel, the tar.gz archive is correct), I've made a new release with the correct files, thx for repporting this bug :)
from prosopopee.
I have installed the latest release fro pypi (prosopopee 1.1.2) and baguetteBox works now correctly.
Thanks heaps for fixing this, @Psycojoker!
from prosopopee.
Related Issues (20)
- full-picture with space in filename does not render HOT 3
- video conversions fail with space in filename
- panorama broken since 729b946 HOT 1
- Images in paragraph section are not scaled appropriately on mobile
- Requirements should be for `path` not `path.py` and then other errors HOT 3
- night_mode breaks site HOT 1
- Line height and image description don't look right on mobile
- autogen not working with my files HOT 7
- Weird thumbnail created for videos on mobile
- Large vertical bordered-pictures are too large on desktop
- 4K videos end up pixelated when the gallery is rendered
- ValueError: too many values to unpack (expected 2)
- Turning off the image captions on mouse over
- AttributeError: module 'jinja2.ext' has no attribute 'with_' HOT 3
- Vertical videos HOT 1
- Animated gifs HOT 1
- yaml options to be improved for latest python HOT 1
- AttributeError: 'NoneType' object has no attribute 'months'
- Python error on macOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prosopopee.