Giter Site home page Giter Site logo

[Bug] - This may be due to code I wrote, not yet merged, but if I navigate forwards and backwards too much, moving backwards stops working about cute HOT 9 CLOSED

KMastroluca avatar KMastroluca commented on July 23, 2024
[Bug] - This may be due to code I wrote, not yet merged, but if I navigate forwards and backwards too much, moving backwards stops working

from cute.

Comments (9)

KMastroluca avatar KMastroluca commented on July 23, 2024

Yes, i narrowed it down. If you hit escape in the home menu, state get mutated in some wierd way that causes an eventual crash

from cute.

KMastroluca avatar KMastroluca commented on July 23, 2024

@PThorpe92 can you reproduce this bug? Idk if its only on windows or if you encounter this as well.

from cute.

PThorpe92 avatar PThorpe92 commented on July 23, 2024

actually no.. i just tried to go back and forth and back and forth from the url screen all the way to the menu, then the saved commands, then back to the url, then downloads.. etc

Actually, nevermind.. I fixed the bug where it crashes if you enter recursive download input. but now it properly directs you to the download screen after you enter input.
I refactored the way the render function works a LOT by just having one big handle_screen() function that takes in the app, frame and screen and i move the massive match statement to another file. which combined with the way you moved the screens to their own files, really helps. so i think after some more cleaning, it should be good.

Tonight i'm gonna work on migrating from tui_input to tui_textarea

EDIT#2: Ok yeah something is f-ed now cuz wget throws an error saying we don't have a url when u give it a url.
Manythings left to fix here but its really coming along ngl...

from cute.

KMastroluca avatar KMastroluca commented on July 23, 2024

Actually, nevermind.. I fixed the bug where it crashes if you enter recursive download input. but now it properly directs you to the download screen after you enter input.

I fixed that too but i havent pushed that fix yet.

from cute.

KMastroluca avatar KMastroluca commented on July 23, 2024

Yeah if I hit escape on the home screen, then go forward twice, then go back, once I cant move my cursor up or down or go back to the home screen, then If i go forward again I can navigate 2 more times in any direction be for I crash.

from cute.

PThorpe92 avatar PThorpe92 commented on July 23, 2024

Hmm. fuck i feel like my next PR is huge and we are gonna have hella conflicts. but im fixing mad spaghetti lol

from cute.

KMastroluca avatar KMastroluca commented on July 23, 2024

no ur fine, just pr and ill pull ur changes.

from cute.

KMastroluca avatar KMastroluca commented on July 23, 2024

is this issue fixed yet? im back btw, i pulled your latest changes.

from cute.

PThorpe92 avatar PThorpe92 commented on July 23, 2024

this bug is fixed for sure. The movement between screens is perfect. good old recursion fixed it believe it or not

from cute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.