Comments (10)
Jeff - I think that we're beginning to push the boundaries of what this plugin is for.
An "isolate" tool doesn't seem appropriate for this plugin, because it requires that the plugin have knowledge of all of the images that are currently on the map. That's not library code, that's application code.
I think the right place for that code is the MapKnitter module in the annotation-interface branch of my fork, or other similar MapKnitter-specific JavaScript code.
from leaflet.distortableimage.
that seems reasonable to me; the same might be said for the hotkeys system; although in both cases, perhaps some of that code could also be provided in code in the examples folder, since they are both extremely useful tools for working with complex maps with multiple images. If you like that idea, we could make a new issue listing things we'd like to move to the /examples/ section and/or excise from the code in favor of an application-specific implementation.
from leaflet.distortableimage.
Sure, good idea - I think the examples are a great place for that code.
On Dec 22, 2014 12:44 PM, "Jeffrey Warren" [email protected] wrote:
that seems reasonable to me; the same might be said for the hotkeys
system; although in both cases, perhaps some of that code could also be
provided in code in the examples folder, since they are both extremely
useful tools for working with complex maps with multiple images. If you
like that idea, we could make a new issue listing things we'd like to move
to the /examples/ section and/or excise from the code in favor of an
application-specific implementation.—
Reply to this email directly or view it on GitHub
#6 (comment)
.
from leaflet.distortableimage.
We could have an outer div
and an inner img
; transforms would affect the outer div, but transparency could affect the inner img
from leaflet.distortableimage.
Trying to solve it with just css made borders disappear (as you mentioned). What you propose sounds like a great idea.
from leaflet.distortableimage.
@jywarren I saw that this issue is referenced in some other issues and also commits. Can you please update the issue or open a new issue if we have more work to do here with a clear goal? Thanks!
from leaflet.distortableimage.
I think the best approach may really be to use a Leaflet polygonal layer to draw a polygon just in front of or behind the image, and to just keep updating it as we do the image itself. This would also enable us to do other things like offset or expand it, and it also wouldn't be affected by the distortion - i.e. edges would have a fixed pixel width instead of the longer edges getting fatter.
from leaflet.distortableimage.
@sashadev-sky Should we close this, then?
from leaflet.distortableimage.
No I never solved this actually. I put it under the pending list in my PR. The thing is the border just experiences the same kind of stretching that the image does when you drag a corner too far in one direction. The transparency part is simple to resolve but implementing polylines that dynamically update to make sure they don't distort will be a little project.
I'm deleting my comment on here about it and my reference to it in multiple image select so there's no confusion about its status
from leaflet.distortableimage.
transferring my initial notes on it from the pending section of that PR:
- Refactor image border drawing (css border is affected by image transparency) #6 -- for this thinking to maybe put all corner point markers in a feature group class together and then use distances between them to create polylines dynamically
from leaflet.distortableimage.
Related Issues (20)
- Unwanted Comment
- Import images from JSON which lack coordinates into sidebar HOT 3
- Think about how to display list of old MapKnitter maps HOT 3
- ?k= Parameter for Shorter Shareable URLs for Legacy Json Files HOT 1
- Remove the use of document.querySelector to a more local search using 'this' HOT 3
- older &json= links don't work now? HOT 5
- Modify Searchbar to have round edge HOT 2
- Wayback machine image URLs still loading images from original Amazon S3 URL HOT 12
- Publishing 0.21.10 on npm HOT 3
- map.remove() won't work when DistortableImage layers exist HOT 4
- callbacks on actions? HOT 2
- Rotate Event Callback HOT 3
- getAngle command errors when image made small HOT 2
- Example not working from `main` rep ? HOT 1
- Empty Tooltip Text Displayed on Images
- React Js Support - Cannot read properties of undefined (reading 'Action') HOT 1
- Error importing into my React component - We need React Support! HOT 1
- Use in React 18: Destroying a component with DistortableImage crashes app HOT 7
- Does this library has typescript support? I am using leaflet in my Angular(16.x.x) project. HOT 4
- leaflet.distortableimage.js:5056 WebSocket connection to 'ws://localhost:8081/ws' failed: HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leaflet.distortableimage.