Comments (6)
I'll see if I can migrate it at least for now
from dataset.
@karlicoss That's great, thank you!
from dataset.
So I did some work on it here, but haven't quite managed to finish :(
A bit stuck, so leaving in here in case someone wants to pick up/help
master...karlicoss:dataset:sqlalchemy-2.0
on sqlalchemy 2.0 I'm getting five tests failing (on sqlite)
FAILED test/test_dataset.py::DatabaseTestCase::test_with - sqlalchemy.exc.InvalidRequestError: This connection has already initialized a SQLAlchemy Transaction() object via begin() or autobegin...
FAILED test/test_dataset.py::TableTestCase::test_table_drop_then_create - sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) table weather has no column named foo
FAILED test/test_dataset.py::TableTestCase::test_update_while_iter - sqlalchemy.exc.InterfaceError: (sqlite3.InterfaceError) Cursor needed to be reset because of commit/rollback and can no longer be fetc...
FAILED test/test_dataset.py::TableTestCase::test_insert_json - AssertionError: 1
FAILED test/test_dataset.py::TableTestCase::test_upsert_many - assert None == 10
For the first three -- not sure what's texactly the issue, for the last two the problems seems to be in reflect_table
-- it seems to drop data or something.
It would be cool to merge the changes as is at least, since they are passing for sqlite on sqlachemy 1.4 and I think would at least allow to at least use dataset in read only mode with sqlalchemy 2.0
But I'm getting one test failure for postgres, weird that it's the only one, can't quite figure out why:
__________________ DatabaseTestCase.test_create_table_no_ids ___________________
self = <test.test_dataset.DatabaseTestCase testMethod=test_create_table_no_ids>
def test_create_table_no_ids(self):
if "mysql" in self.db.engine.dialect.dbapi.__name__:
return
if "sqlite" in self.db.engine.dialect.dbapi.__name__:
return
table = self.db.create_table("foo_no_id", primary_id=False)
> assert table.table.exists()
from dataset.
The 5 errors are all because SQLAlchemy removes auto commit in 2.0.0b1 version, I fix it and all tests passed. However I am not sure there is absolute no any bugs
from dataset.
Related Issues (20)
- enums and decimals are not supported
- inconsistent Upsert documentation HOT 3
- Increase a value without reading last value
- create_table error when source data has ID field
- SQL Alchemy links in docs broken
- CompileError at `update_many` due to column in a dataset doesn't exist in a db HOT 2
- TypeError: MetaData.__init__() got an unexpected keyword argument 'bind' under sqlalchemy 2.0 HOT 1
- Remove duplicates from a table
- Dataset ignore my primary key HOT 3
- SQLAlchemy examples in the doc
- Parameter passing exception
- dataset wrapper for With statement HOT 3
- bug with alembic=1.11 HOT 1
- Warn if user accidentally uses set as advanced filter?
- Current use of Database.op.add_column() does not work with later versions of alembic HOT 1
- Why doesn't it automatically recycle connections in the connection pool? HOT 1
- Python 3.11 HOT 2
- where HOT 1
- add_column() takes 3 positional arguments but 4 were given HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dataset.