Looking for help: migrating dataset to sqla 2.0.0

[pudo]

Looking for help: migrating dataset to sqla 2.0.0

[karlicoss]

I'll see if I can migrate it at least for now

[pudo]

@karlicoss That's great, thank you!

[karlicoss]

So I did some work on it here, but haven't quite managed to finish :(
A bit stuck, so leaving in here in case someone wants to pick up/help

master...karlicoss:dataset:sqlalchemy-2.0

on sqlalchemy 2.0 I'm getting five tests failing (on sqlite)

FAILED test/test_dataset.py::DatabaseTestCase::test_with - sqlalchemy.exc.InvalidRequestError: This connection has already initialized a SQLAlchemy Transaction() object via begin() or autobegin...
FAILED test/test_dataset.py::TableTestCase::test_table_drop_then_create - sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) table weather has no column named foo
FAILED test/test_dataset.py::TableTestCase::test_update_while_iter - sqlalchemy.exc.InterfaceError: (sqlite3.InterfaceError) Cursor needed to be reset because of commit/rollback and can no longer be fetc...
FAILED test/test_dataset.py::TableTestCase::test_insert_json - AssertionError: 1
FAILED test/test_dataset.py::TableTestCase::test_upsert_many - assert None == 10

For the first three -- not sure what's texactly the issue, for the last two the problems seems to be in reflect_table -- it seems to drop data or something.

It would be cool to merge the changes as is at least, since they are passing for sqlite on sqlachemy 1.4 and I think would at least allow to at least use dataset in read only mode with sqlalchemy 2.0

But I'm getting one test failure for postgres, weird that it's the only one, can't quite figure out why:

__________________ DatabaseTestCase.test_create_table_no_ids ___________________

self = <test.test_dataset.DatabaseTestCase testMethod=test_create_table_no_ids>

    def test_create_table_no_ids(self):
        if "mysql" in self.db.engine.dialect.dbapi.__name__:
            return
        if "sqlite" in self.db.engine.dialect.dbapi.__name__:
            return
        table = self.db.create_table("foo_no_id", primary_id=False)
>       assert table.table.exists()

[M4rque2]

The 5 errors are all because SQLAlchemy removes auto commit in 2.0.0b1 version, I fix it and all tests passed. However I am not sure there is absolute no any bugs