Comments (4)
Hi there,
This was something we didn't think about, and I do like the idea to fire the events when a tour is in progress rather than no check at all.
@mmorainville your input would be interesting :)
from vue-tour.
Indeed, it's a great idea! Thanks @zanedev for the input.
However we have to think of every use case, wouldn't be a problem if one day we want to make a hook available when the tour is not started yet or when the tour is finished?
For example beforeStart and afterEnd callbacks?
Otherwise the namespace would also be a good idea, we should take a closer look and make some tests.
from vue-tour.
Hi there, its been two years since the bug has been reported and it is still present :) .
I think it would be enough to move window.addEventListener('keyup', this.handleKeyup) from mounted() to start()
from vue-tour.
Hi @buksy90,
Indeed we are at the same too cautious to add features without thorough thinking (to avoid regressions or breaking changes) and too busy on other projects to keep track of old issues like this one.
But in this case as you said, it should be enough to move the listener in the start() method (and thus to remove the listener in the stop method). Unless two tours run at the same time... which is not really not recommended but possible and maybe some people do that? But in this case the behavior should be the same as now, so it's not really breaking anyway...
Then, a PR would be welcome on this one, it's a good first issue to start contributing. :)
from vue-tour.
Related Issues (20)
- Build fails in vue-tour (npm run build)
- Tour stops when targets aren't found HOT 2
- Memory leak when using VueTour in vue-test-utils [BUG]
- Vue 3 Compatibility HOT 5
- Is there a way to install locally rather than globally HOT 1
- Unable to point to elements in child components using vue 2 and quasar
- Disable interaction with any elements while tour is displayed HOT 3
- Stop the tour HOT 1
- After adding v-if to the component, the component will not be destroyed if the condition is false. HOT 2
- Install with Nuxt3 HOT 2
- Embed Image in tour HOT 1
- Can I pause a tour? HOT 1
- How to integrate with vite ? HOT 2
- Cross iFrame
- Switching from vue-cli to vite
- the callback which name is onFinish does not trigger HOT 1
- In modal position of the v-step is wrong
- Support for nuxt 3
- Slots will be added very shortly to support with vue 3.
- Position of the step is not updating as per the layout shifts of the element in the DOM
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-tour.