Cannot compile against 1.8.4 in Fedora 29

[pupnp]

Cannot compile against 1.8.4 in Fedora 29

[mrjimenez]

Hi,

The problem here is that you cannot dereference info. You must use one of the accessing functions. In this case, you should use something like this:

int ret; ret = UpnpFileInfo_set_ContentType(info, db->getTrackMIME(db->getTrackId(0, 0, 0, m_path, NULL )));

Notice that I have removed the strdup() because that would leak memory since set functions copy memory contents to their own managed buffers. By the way, avoiding those memory leaks is the reason the new API has been created.

The key to understand this relative mess, is to look at these files:

./upnp/inc/FileInfo.h
./upnp/inc/TemplateInclude.h
./upnp/inc/TemplateSource.h

Also note that DOMString is defined in ixml.h to be char *

Once you get used to it, it is really not that confuse.

Best regards,
Marcelo.

[gone-bush]

Thank you for your prompt and informative reply - I am now able to compile against 1.8.4.

But, and for the record, where are these setters/getters documented (I managed to guess the ones I needed)?

Cheers,
Kevin

[mrjimenez]

Hi Kevin,

Now you hit a key point: unfortunately, they are not formally documented. :( The best we can do now would be to write a text file and explain how it works and for the people to look at the appropriate include files.

When I created the templates, I tried to auto-document them using Doxygen. I believe that this work can succeed, but I currently have no time resources to dedicate to it.

All this template generated code is a C pre-processor hack. The original idea was to get the result of the pre-processor and pass it through Doxygen. If I recall correctly, the Doxygen stuff is mostly already there.

Hopefully, we can still do that one day.

Best regards,
Marcelo.

[Vollstrecker]

I think documenting the removed templates isn't needed anymore. Unfortunately I can't close anything here.

[mrjimenez]

The templates are gone, but the API is now documented, at least I think it is.

As for closing issues, @Vollstrecker , you can do it if you want.