off_t being part of the API results in headaches

[pupnp]

off_t being part of the API results in headaches

[mrjimenez]

I like that solution. The author also comments on using int64_t, but he also discourages it because it may hide seek offset problems. If we must have off_t in the API, the proper solution is the first one, don't let anyone compile against the lib without large file support. Throwing an error at compile/configure time seems ok to me.

[whyman]

I found this an interesting read: http://ac-archive.sourceforge.net/largefile/off_t_headers.html

Alternatively we could we simply use unit64_t instead?

[whyman]

So those checks are already present:

AC_SYS_LARGEFILE_SENSITIVE is commented out:
https://github.com/mrjimenez/pupnp/blob/57cf7774e15f2db0a62039065a84463a53b7cd80/configure.ac#L408

UpnpGlobal.h has the check:
https://github.com/mrjimenez/pupnp/blob/02f6b710ad7e108014787db433ab94d698bbd01e/upnp/inc/UpnpGlobal.h#L10

Does it simply need uncommenting?

[whyman]

Seems it was commented in "Largefile support" mrjimenez@f1cc7db.

I am assuming this means that MYLIB_LARGEFILE_SENSITIVE will never be defined, so maybe change the check to simply : #if _FILE_OFFSET_BITS+0 != 64

[ukleinek]

I'm working on a more robust solution, give me some more time