Giter Site home page Giter Site logo

Comments (10)

muster-mark avatar muster-mark commented on May 21, 2024 1

@OrKoN Yes I merely meant the one created by printing directly in Chrome. tagged: false produces the same output. But actually in Firefox it does look like this known issue: mozilla/pdf.js#5046

from puppeteer.

github-actions avatar github-actions commented on May 21, 2024

The issue has been labeled as confirmed by the automatic analyser.
Someone from the Puppeteer team will take a look soon!


Analyzer run

from puppeteer.

OrKoN avatar OrKoN commented on May 21, 2024

@muster-mark could you please provide a PDF that you get?

from puppeteer.

OrKoN avatar OrKoN commented on May 21, 2024

Do you get a different result if you print using the regular print dialog in Chrome and choose save to PDF?

from puppeteer.

Lightning00Blade avatar Lightning00Blade commented on May 21, 2024

This looks like an issue with the viewer that's being used
From my VSCode extension I get the described problem (Also I get a File is corrupted error):
image
But opening the same file in Chrome give the correct color:
image

from puppeteer.

muster-mark avatar muster-mark commented on May 21, 2024

@OrKoN @Lightning00Blade
Please see attached printed_from_puppeteer.pdf and printed_from_chrome.pdf

printed_from_chrome.pdf
printed_from_puppeteer.pdf

Lighting00Blade, you are correct that it does depend on the viewer. I was using Firefox to view the pdfs. It displays correctly in Chrome, as you note, and also Adobe Acrobat reader. Though OrKoN, yes I do get a different result when printing from chrome, as that pdf displays correctly in Firefox.

I am not sure we can we be sure the viewers are to blame here, since the issue is apparent in 2 separate viewers (Firefox and vscode). Perhaps the pdf itself is in fact the issue, but chrome and adobe acrobat are more tolerant of whatever that issue is.

from puppeteer.

OrKoN avatar OrKoN commented on May 21, 2024

So if it is shown correctly in Chrome and Adobe Acrobat reader, I believe this is an issue with the specific PDF viewer.

from puppeteer.

muster-mark avatar muster-mark commented on May 21, 2024

@OrKoN FWIW Safari also seems to have an issue with the puppeteer file. Although it displays it correctly, it takes an astonishing 35 seconds to render the table, whereas the pdf created by printing in chrome renders almost immediately. That's despite the table being a lot smaller in the puppeteer-generated file (I realise now I did not print the same exact thing in the 2 pdfs).

from puppeteer.

muster-mark avatar muster-mark commented on May 21, 2024

@OrKoN Also, Apple Preview renders the chrome generated version instantantaneously, but takes about 5s for the puppeteer one.

from puppeteer.

OrKoN avatar OrKoN commented on May 21, 2024

@muster-mark Puppeteer's one are also generated by Chrome as Puppeteer does not generate PDFs on its own. Have you tried tagged: false in Puppeteer? Perhaps it is worth filing a bug at crbug.com ?

from puppeteer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.