terminal widget problem

[fredx181]

terminal widget problem

[01micko]

Hello @fredx181

@woodenshoe-wi can you possibly fix this problem?

Else I'll have to revert to the older automaton.c

[woodenshoe-wi]

Maybe, I think I found the commit that broke it in libvte.

https://gitlab.gnome.org/GNOME/vte/-/commit/165b0cf9c40cddf

So I should just have to add another version check and use gtk_style_context_get_padding, but that should be for GTK3?

The inner-border property is still used by vte-0-36 but was switched to padding again in vte-0-38.

The deprecated vte_terminal_get_padding is still available in vte-0-36 so there isn’t really any need to use the inner-border property because it only lasted a little bit longer than vte_terminal_get_padding.

[01micko]

Thanks @woodenshoe-wi

I'll wait and see.

[01micko]

Reported here that the problem is fixed, closing.

[woodenshoe-wi]

I see a divergence in the source developing...

Wiak seems to have a fix for 'inner-border',
http://www.murga-linux.com/puppy/viewtopic.php?p=1060379#1060379

but doesn’t seem to be too interested in Gtk+3 support.

I don’t consider myself to be the current gtkdialog developer, I just wanted to get Gtk+3 support working. Since no good deed goes unpunished 😄 I don’t really want to make any changes myself that are not necessary for Gtk+3 support or bug fixes.

So I guess it is your call @01micko if you want wiak’s fix. If you do, I think you will have to mention it, because wiak wrote:

Since vte_terminal_get_padding() is considered fine by maintainer at 01micko legacy gtkdialog repo I won't push this change up there ...

On another subject, I have converted the gtkdialog wiki to GitHub format... See https://github.com/01micko/gtkdialog/pull/83#issuecomment-385745505

Do you want to clone it to your personal account or the puppylinux-woof-CE account?