Prompt disappears when entering some folders

[heyarne]

Prompt disappears when entering some folders

[edouard-lopez]

As mentioned in this fisherman issue, it might be due to a previous install of vkovtash/pure that was cached in the fishfile.

[heyarne]

What's even weirder: I issue git checkout master and the prompt reappears in its old glory. The branch name I was on before was bugfix/filter-is-not-a-function.

[oranja]

This seems like a bug in handling some git repo state.
To get a better idea and to cross out or consider other possibilites, are you using virtualenv or something similiar in the directories that fail?
In general, can you point out to anything in common to the repositories that make pure fail? submodules? detached heads? branches? remotes? unstaged changes? local unpushed commits?

[heyarne]

I do not have a virtualenv in it. The repo does not have submodules, it's not in detached head state, unstaged changes or not don't really make a difference. I'll try to find more cases and I'll try to find some common properties in them.

[vimkin]

+1
Also had the same issue a while ago, if needed would like to assist in fixing it

[rafaelrinaldi]

@heyarne Thanks for the report, this behavior does look weird indeed. Please, try to come up with reproducible steps so we can better assist you.

@vadikace You are more than welcome to jump into this issue if you feel like it 👍

[heyarne]

I've been able to reproduce the behavior whenever the path + git status exceeds a certain length. I attached some screenshots to clarify what exactly I mean:

Terminal at 104x24, length of path + git status: 94 chars

Terminal at 103x24, length of path + git status: 94 chars (same as above)

Terminal at 104x24, length of path + git status: first 94 chars, then 95 chars

Terminal at 20x11, length of path: 1

Terminal at 20x11, length of path: 10

Terminal at 21x11, length of path: 10

I hope this is clear enough and makes this reproducible. I'm using Terminal.app Version 2.8, macOS 10.13 and fish version 2.7.1.

[rafaelrinaldi]

@heyarne Thanks for the details. We will look into it.

@vadikace Still wanna attempt a PR?

[edouard-lopez]

Before update

I can't reproduce with:

❯ cd ~/.config/fisherman/pure/
❯ git log | head -n 1
❯ commit 69c14e0d89b99f61ced5c2ab97d906a533cab3d5

/tmp 
❯ mkdir -p /tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque

/tmp 
❯ cd /tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque

/tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque 
❯ git init
Initialized empty Git repository in /tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque/.git/

/tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque master 
❯ echo 'hello world'
hello world

/tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque master 
❯ 

After update

❯ fisher update pure
Updating 1 plugin
type: Could not find “”
OK Pulled 87 new commit/s pure
Done in 2s 769ms
/data/settings/.config/fisherman/pure master 
❯ git log | head -n 1
commit 47722fa666823d2a35e6d2bf8d2048ad18b3a854

Still no problem:

❯ cd /tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque

/tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque master 
❯ echo 'hello world'
hello world

/tmp/Quo/consequatur/ut/dolore/ducimus/et/vero/soluta./Vel/est/alias/consequatur./Nobis/nisi/voluptatum/libero/suscipit/porro/libero/qui/eaque master 
❯ 

@heyarne Can you try on a clean environment without plugins?

[edouard-lopez]

@heyarne
I created a docker image pure-fish if you want to try on a clean env.

cc @rafaelrinaldi

[heyarne]

Oh wow... this is a bit embarassing. fisher install pure doesn't install rafalrinaldi/pure but instead pure from this repo. Indeed, couldn't reproduce the issue after executing fisher rm pure; fisher install rafaelrinaldi/pure. I'm going to close this, thanks for the effort and sorry! I assumed there was just one port.