Giter Site home page Giter Site logo

Comments (9)

felixSchl avatar felixSchl commented on June 25, 2024

pulp init && pulp test works, btw. I think it has to do with the node env not being set correctly.

from pulp.

felixSchl avatar felixSchl commented on June 25, 2024

It's because main.js is picked up as the main module, but the default skeleton creates a Main purescript module, which results in output/Main/index.js. Node will import main.js on require('Main'), rather than Main/index.js.

from pulp.

bodil avatar bodil commented on June 25, 2024

Proposed solution would be to not store the wrapper file inside the build directory at all, rather using the temp module to store it somewhere out of the way, then get rid of it automatically when it's no longer needed.

from pulp.

felixSchl avatar felixSchl commented on June 25, 2024

I appreciate it's not an all encompassing solution but that is besides the point of the pull request. The initial experience of starting with pulp is what mattered to me. If I change things, I can expect unforeseen things to happen.

from pulp.

bodil avatar bodil commented on June 25, 2024

I appreciate that, I'd still like to get the correct solution in asap. And I'm working on it as we speak, give me a moment. :)

from pulp.

felixSchl avatar felixSchl commented on June 25, 2024

That commit introduces a Type error in run.js on line 22. Just add the additional parameter to fs.write and it works: felixSchl/pulp@908600e

from pulp.

bodil avatar bodil commented on June 25, 2024

That's curious. What Node version are you on, just for reference? The docs have that parameter down as optional.

from pulp.

felixSchl avatar felixSchl commented on June 25, 2024

The docs specify the parameter as optional only if the other optional parameter position has been specified - note the nested brackets. You can refer to the implementation which has not changed since mid july 2013.

from pulp.

bodil avatar bodil commented on June 25, 2024

The code seems to willingly accept both, but I agree with your interpretation of the doc. JS is terrible. :(

It did run correctly in its previous form on my v0.12.0 version of Node, though, which is why I'm puzzled.

from pulp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.