Giter Site home page Giter Site logo

Comments (4)

cwhanse avatar cwhanse commented on June 18, 2024

The change in pvlib labels windows on the left by default, while previous behavior used centered labels.

Other way around; before v0.8.1, pvlib used left labels. pvlib v0.8.1 uses centered labels.

from pvanalytics.

wfvining avatar wfvining commented on June 18, 2024

Other way around; before v0.8.1, pvlib used left labels. pvlib v0.8.1 uses centered labels.

Thanks, updated.

from pvanalytics.

wfvining avatar wfvining commented on June 18, 2024

Actually, the alignment is not exposed in the pvlib API. We should probably just accept the centered labels here, and remove/rewrite tests that relied on left-aligned labels. I'm thinking that my approach to testing this function was flawed to begin with, it might be better to mock the pvlib function and check that the window/scale are computed correctly and passed the pvlib function (otherwise we are spending a bunch of effort testing code that isn't even part of pvanalytics).

from pvanalytics.

cwhanse avatar cwhanse commented on June 18, 2024

Tests for clearsky.reno fail because of a bug in pvlib.clearsky #pvlib/pvlib-python#1241

from pvanalytics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.