inconsistent encoding for string message.

[pvorb]

inconsistent encoding for string message.

[pvorb]

Sorry, but I don't understand where this is an issue.

so that i'm not getting the result i'm expecting

Could you give me an example with the exact results you get and the ones you are expecting?

[salba]

var md5 = require('./../../lib/MD5/');

describe('test md5', function () {
    it('should produce binary', function () {
        var hash1, hash2, hash3
        hash1 = md5('abc', {asString: true});
        hash2 = md5(hash1 + 'a', {asString: true});
        hash3 = md5(hash1 + 'a');
        console.log('hash1', hash1);
        console.log('hash2', hash2);
        console.log('hash3', hash3);
        //current code using utf8 on message
        //output is:
        //hash1 �P�<ÒO°Ö�?}(ár
        //hash2 =ªÙmeÐñY��ìj^X-û
        //hash3 3daad96d65d0f159988fec6a5e582dfb

//expected output is: (since the hash1 is a string with binary encoding, hash2 and hash3 should honor that encoding)
        //hash1 �P�<ÒO°Ö�?}(ár
        //hash2 Å(OQä®Æ8Ái
        //hash3 131f0ac52813044f5110e4aec638c169
    });
});

[pvorb]

But hash1 + 'a' results in '�P�<ÒO°Ö�?}(ára', doesn't it? And that is hashed correctly.

I cannot change JavaScript's handling of strings.

[salba]

nope - for the current md5 module hash1 + 'a' results in "=ªÙmeÐñY��ìj^X-û" whereas below the hash1 + 'a' results in "Å(OQä®Æ8Ái". Basically, the current MD5 module does not give the option of using a binary encoded string in the message. It always processes the string as UTF8 but will output it as a binary string if you pass the option.asString=true. (Just seems inconsistent).

I'm hoping you can give an option as to what encoding to use for the string message.

Thanks.

Here's a sample code using node's basic crypto where I expect hash2 as "Å(OQä®Æ8Ái"

Code:

var crypto = require('crypto');

describe('test md5 crypto', function () {
    it('should produce binary', function () {
        var md5, hash1, hash2, hash3
        md5 = crypto.createHash('md5');
        md5.update('abc', 'binary');
        hash1 = md5.digest('binary');
        md5 = crypto.createHash('md5');
        md5.update(hash1 + 'a', 'binary');
        hash2 = md5.digest('binary');
        md5 = crypto.createHash('md5');
        md5.update(hash1 + 'a', 'binary');
        hash3 = md5.digest('hex');
        console.log('hash1', hash1);
        console.log('hash2', hash2);
        console.log('hash3', hash3);

        //hash1 �P�<ÒO°Ö�?}(ár
        //hash2 Å(OQä®Æ8Ái
        //hash3 131f0ac52813044f5110e4aec638c169
    });
});

[pvorb]

Okay, I get your point.

You can send me a pull request that implements this, if you really need such a feature in this module. Otherwise use crypto instead.

[pvorb]

resolved by #7