Giter Site home page Giter Site logo

Comments (6)

hbredin avatar hbredin commented on August 14, 2024

I noticed the same issue when working on DIHARD challenge. I would argue that this is bad practice from DIHARD organizers to use the same name for different files... but now the harm is done :)

The solution based on the additional split field should work.
I don't foresee any issue with the rest of pyannote ecosystem (though I might be wrong because I haven't had my morning coffee yet...)

An alternative is to use /path/to/dihard_data/{uri}.flac as matching pattern and use dev/data/single_channel/flac/DHxxxx as actual uri. This might cause an issue with pyannote-metrics.py evaluation script. In particular, get_hypothesis should probably be updated to support this kind of uri mismatch: https://github.com/pyannote/pyannote-metrics/blob/efa42b99f420210e4eb0225a1be972718b0a6bc2/scripts/pyannote-metrics.py#L142-L181

from pyannote-database.

hadware avatar hadware commented on August 14, 2024

Well, i'm going to try the 'split' method out and see how it goes.

Regarding the alternative method, I gazed intensely at the code but couldn't see anything that would be disturbed by having subpaths as uri's.

from pyannote-database.

geniki avatar geniki commented on August 14, 2024

In our case at least, I haven't seen the benefit of having the automatic FileFinder over using fixed paths within a dataset. As a downside, it seems to take some time to find all files for a bigger dataset, slowing startup time.

from pyannote-database.

hadware avatar hadware commented on August 14, 2024

Just so you know, we decided (someone else from CoML) to just remodel the dataset with a script and use a good ol' "Generic speaker diarization protocols" to save us the hassle of having to implement an actual DB module.

from pyannote-database.

hbredin avatar hbredin commented on August 14, 2024

FYI, I am currently working on v2 of pyannote.audio where you will be able to use your own piece of code in place of FileFinder, by overriding the "audio" preprocessors.

I am also playing with lazy loading in pyannote.database so that training starts as soon as possible (without looking for all files first). If you want to try it (and provide me with feedback), simply checkout and install lazy_preprocessors branch of pyannote.database.

from pyannote-database.

hbredin avatar hbredin commented on August 14, 2024

Closing in preparation of pyannote.database 4.0 which comes with a complete rewrite of custom protocols. See custom branch for details.

from pyannote-database.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.