Warning: Existing key "annotation" may have been modified.

[PaulLerner]

Warning: Existing key "annotation" may have been modified.

[hbredin]

This is due to the fact that annotation is now cropped to annotated extent using a preprocessor:

pyannote-database/pyannote/database/protocol/speaker_diarization.py

Lines 178 to 180 in 3852372

	preprocessors["annotation"] = functools.partial(
	crop_annotation, existing_preprocessor=preprocessors.get("annotation", None)
	)

In pyannote.database 3.x, it was done directly in add_custom_protocol without any warning.

We could be smarter and only print this warning when the value actually changed.
Relevant code is here:

pyannote-database/pyannote/database/protocol/protocol.py

Lines 125 to 128 in a34386d

	# warn the user when a precomputed key is modified
	if key in self._store:
	msg = 'Existing key "{key}" may have been modified.'
	warnings.warn(msg.format(key=key))

Pull request welcome ;-)