Clarification around failed tests

[pybitcash]

Clarification around failed tests

1. Can you fix that?

2. Those weren't failing on my end but we can pull them out, unless those are generic ones and will be fixed by adding another testnet endpoint. Only have the one. Would rather add a second testnet endpoint and have those tests working, unless they are API-specific and not generic NetworkAPI.

3. That should work, but the whole thing is kinda glitchy. Needs to be made more robust.

[AustEcon]

1. Yep included in custom pushdata PR
2. I'll see if it's possible to get these working...or if it's an API issue.
3. Okay. That's all good. Just wondered. Thanks :)

Sounds good, thank you! No problem.

Hey! I'm getting failed tests now.

nosetests -vx...

tests.test_wallet.TestPrivateKeyTestnet.test_get_unspent ... ok
tests.test_wallet.TestPrivateKeyTestnet.test_init_default ... ok
tests.test_wallet.TestPrivateKeyTestnet.test_repr ... ok
tests.test_wallet.TestPrivateKeyTestnet.test_send ... ERROR

======================================================================
ERROR: tests.test_wallet.TestPrivateKeyTestnet.test_send
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/user/repos/bitcash/tests/test_wallet.py", line 245, in test_send
    private_key.send([('n2eMqTT929pb1RDNuqEnxdaLau1rxy3efi', 10000, 'satoshi')])
  File "/home/user/repos/bitcash/bitcash/wallet.py", line 586, in send
    outputs, fee=fee, leftover=leftover, combine=combine, message=message, unspents=unspents
  File "/home/user/repos/bitcash/bitcash/wallet.py", line 547, in create_transaction
    return create_p2pkh_transaction(self, unspents, outputs, custom_pushdata=custom_pushdata)
  File "/home/user/repos/bitcash/bitcash/transaction.py", line 292, in create_p2pkh_transaction
    script = hex_to_bytes(unspent.script)
  File "/home/user/repos/bitcash/bitcash/utils.py", line 26, in hex_to_bytes
    if len(hexed) & 1:
TypeError: object of type 'NoneType' has no len()
-------------------- >> begin captured logging << --------------------
urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): tbch.blockdozer.com
urllib3.connectionpool: DEBUG: https://tbch.blockdozer.com:443 "GET /api/addr/bchtest:qzvsaasdvw6mt9j2rs3gyps673gj86flev3z0s40ln/utxo HTT
root: DEBUG: Estimated fee: 19848 satoshis for 4962 bytes
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 145 tests in 35.873s

FAILED (errors=1)

Can you take a look into this?

[AustEcon]

My internet is down all this week and need to arrange it to be fixed (again) and I have some serious deadlines at work. I don't know when I will be able to. I can't think of why anything I've changed would affect testnet but leave mainnet perfectly happy... I can look when I get internet back and see if I can generate the same error code though...

I wonder if it works with the latest release before all the changes...

Alright, thanks for letting me know. Sorry for the wait on my end.

I'll take a stab unless I see something from you on it. I just don't want to assume anything about the code and break what you've written.

[AustEcon]

I can't help sorry. I'm snowed under. Lots of other stuff to take care of now.

Ok, thanks for letting me know! Appreciate your contributions thus far :).

[merc1er]

I think this can be closed too @teran-mckinney :)