Giter Site home page Giter Site logo

Comments (4)

reaperhulk avatar reaperhulk commented on July 21, 2024

As you noted, it was added for compatibility, but also to allow users to do OpenSSH private key encryption (#56). The bcrypt_pbkdf is almost pbkdf2, but changes a few small details and uses a "bcrypt hash" (see: https://github.com/pyca/bcrypt/blob/master/src/_csrc/bcrypt_pbkdf.c#L29-L49).

So it isn't using bcrypt the KDF, but it is using the expanded blowfish key schedule. Blame OpenBSD 😄. I definitely agree that we should document this function much better and steer users away from it since it is of limited utility unless you're looking for compatibility with OpenSSH private key encryption. A warning on low iteration count is probably also a good idea in general and I'd be happy to review a PR if you're interested in submitting one!

from bcrypt.

lgommans avatar lgommans commented on July 21, 2024

I'd be happy to review a PR if you're interested in submitting one!

Sure, it doesn't sound like much work. Would you say a warning (to sys.stderr) is better or should it throw an exception (since it shouldn't happen: any code doing that is broken crypto)?

from bcrypt.

reaperhulk avatar reaperhulk commented on July 21, 2024

I think a warning is appropriate. I'm concerned about using an exception because if a user has a pre-existing openssh key then deriving the key using bcrypt.kdf should not fail even if their iteration count was unwisely low.

from bcrypt.

lgommans avatar lgommans commented on July 21, 2024

Fixed in pull request #104

from bcrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.