24.1.0: pytest fails in 3 units and some pytest warnings

[kloczek]

24.1.0: pytest fails in 3 units and some pytest warnings

[alex]

No, we won't drop 37 until our users stop using it.

…

On Thu, Mar 14, 2024, 11:01 AM Tomasz Kłoczko ***@***.***> wrote: Closed #1298 <#1298> as completed. — Reply to this email directly, view it on GitHub <#1298 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBDTL7QNEY7CLIHB3LTYYG3TZAVCNFSM6AAAAABEV5WRF6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGEYTSNZZGU2TCNA> . You are receiving this because you commented.Message ID: ***@***.***>

[alex]

It looks like you're still installing flaky, even though it was dropped as a dependency in 510b0e5

[kloczek]

One sec let me check 😋

[kloczek]

Hmm ..

• that commit is not part of the master 24.1.0...main
• I cannot apply patch from that commit on top of 24.1.0

warning: Downloading https://github.com/pyca/pyopenssl//archive/24.1.0/python-pyOpenSSL-24.1.0.tar.gz to /home/tkloczko/rpmbuild/SOURCES/python-pyOpenSSL-24.1.0.tar.gz
warning: Downloading https://github.com/pyca/pyopenssl//commit/510b0e57.patch#/python-pyOpenSSL-Stop-using-flaky-lib-use-pytest-rerunfailures-instead.patch to /home/tkloczko/rpmbuild/SOURCES/python-pyOpenSSL-Stop-using-flaky-lib-use-pytest-rerunfailures-instead.patch
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.4zzikU
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ cd /home/tkloczko/rpmbuild/BUILD
+ rm -rf pyopenssl-24.1.0
+ /usr/lib/rpm/rpmuncompress -x /home/tkloczko/rpmbuild/SOURCES/python-pyOpenSSL-24.1.0.tar.gz
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd pyopenssl-24.1.0
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/lib/rpm/rpmuncompress /home/tkloczko/rpmbuild/SOURCES/python-pyOpenSSL-Stop-using-flaky-lib-use-pytest-rerunfailures-instead.patch
+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f
1 out of 1 hunk FAILED -- saving rejects to file setup.py.rej
3 out of 3 hunks FAILED -- saving rejects to file tests/test_crypto.py.rej
2 out of 2 hunks FAILED -- saving rejects to file tests/test_ssl.py.rej
1 out of 1 hunk FAILED -- saving rejects to file tests/util.py.rej
error: Bad exit status from /var/tmp/rpm-tmp.4zzikU (%prep)

🤔

[kloczek]

flaky still is used in pytest marks

[tkloczko@pers-jacek pyopenssl-24.1.0]$ grep -r flaky
tests/test_ssl.py:    @pytest.mark.flaky(reruns=2)
tests/test_crypto.py:    @pytest.mark.flaky(reruns=2)
tests/test_crypto.py:    @pytest.mark.flaky(reruns=2)

Without installed flaky pytest fails on those marks

==================================================================================== test session starts ====================================================================================
platform linux -- Python 3.9.18, pytest-8.1.1, pluggy-1.4.0
OpenSSL: b'OpenSSL 3.2.1 30 Jan 2024'
cryptography: 42.0.5
rootdir: /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0
configfile: pyproject.toml
testpaths: tests
collected 6 items / 2 errors

========================================================================================== ERRORS ===========================================================================================
___________________________________________________________________________ ERROR collecting tests/test_crypto.py ___________________________________________________________________________
'flaky' not found in `markers` configuration option
____________________________________________________________________________ ERROR collecting tests/test_ssl.py _____________________________________________________________________________
'flaky' not found in `markers` configuration option
===================================================================================== warnings summary ======================================================================================
tests/test_crypto.py:21
tests/test_crypto.py:21
  /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_crypto.py:21: DeprecationWarning: sign() is deprecated. Use the equivalent APIs in cryptography.
    from OpenSSL.crypto import (

tests/test_crypto.py:21
tests/test_crypto.py:21
  /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_crypto.py:21: DeprecationWarning: verify() is deprecated. Use the equivalent APIs in cryptography.
    from OpenSSL.crypto import (

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================================== short test summary info ==================================================================================
ERROR tests/test_crypto.py - Failed: 'flaky' not found in `markers` configuration option
ERROR tests/test_ssl.py - Failed: 'flaky' not found in `markers` configuration option
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=============================================================================== 4 warnings, 2 errors in 0.89s ===============================================================================

[kloczek]

Ok so looks like remove using flaky is not fully finished. Am I right? 😋

[alex]

No, those marks are from pytest-rerunfailures, not flaky

…

On Thu, Mar 14, 2024, 9:39 AM Tomasz Kłoczko ***@***.***> wrote: Ok so looks like remove using flaky is not fully finished. Am I right? 😋 — Reply to this email directly, view it on GitHub <#1298 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBFW47I7YBKFX5BGFYLYYGSCJAVCNFSM6AAAAABEV5WRF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXGQ4DINZVHE> . You are receiving this because you commented.Message ID: ***@***.***>

[kloczek]

No, those marks are from pytest-rerunfailures, not flaky

One sec .. 😋

[kloczek]

OK so pytest is OK however I see some warnings

Here is pytest output:

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pyOpenSSL-24.1.0-2.fc36.x86_64/usr/lib64/python3.9/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pyOpenSSL-24.1.0-2.fc36.x86_64/usr/lib/python3.9/site-packages
+ /usr/bin/pytest -ra -m 'not network'
============================= test session starts ==============================
platform linux -- Python 3.9.18, pytest-8.1.1, pluggy-1.4.0
OpenSSL: b'OpenSSL 3.2.1 30 Jan 2024'
cryptography: 42.0.5
rootdir: /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0
configfile: pyproject.toml
testpaths: tests
plugins: rerunfailures-12.0
collected 504 items

tests/test_crypto.py ................................................... [ 10%]
........................................................................ [ 24%]
........................................................................ [ 38%]
..........................................................               [ 50%]
tests/test_debug.py .                                                    [ 50%]
tests/test_rand.py ....                                                  [ 51%]
tests/test_ssl.py ...................................................... [ 61%]
........................................................................ [ 76%]
........................................................................ [ 90%]
...............................................                          [ 99%]
tests/test_util.py .                                                     [100%]

=============================== warnings summary ===============================
tests/test_crypto.py:21
  /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_crypto.py:21: DeprecationWarning: sign() is deprecated. Use the equivalent APIs in cryptography.
    from OpenSSL.crypto import (

tests/test_crypto.py:21
  /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_crypto.py:21: DeprecationWarning: verify() is deprecated. Use the equivalent APIs in cryptography.
    from OpenSSL.crypto import (

tests/test_ssl.py::TestContext::test_set_cipher_list[hello world:AES128-SHA1]
  /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_ssl.py:499: DeprecationWarning: str for cipher_list is no longer accepted, use bytes
    context.set_cipher_list(cipher_string)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================= 504 passed, 3 warnings in 7.45s ========================

[alex]

Yes, those warnings are expected at this time

…

On Thu, Mar 14, 2024, 10:45 AM Tomasz Kłoczko ***@***.***> wrote: OK so pytest is OK however I see some warnings Here is pytest output: + PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pyOpenSSL-24.1.0-2.fc36.x86_64/usr/lib64/python3.9/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pyOpenSSL-24.1.0-2.fc36.x86_64/usr/lib/python3.9/site-packages+ /usr/bin/pytest -ra -m 'not network'============================= test session starts ==============================platform linux -- Python 3.9.18, pytest-8.1.1, pluggy-1.4.0OpenSSL: b'OpenSSL 3.2.1 30 Jan 2024'cryptography: 42.0.5rootdir: /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0configfile: pyproject.tomltestpaths: testsplugins: rerunfailures-12.0collected 504 items tests/test_crypto.py ................................................... [ 10%]........................................................................ [ 24%]........................................................................ [ 38%].......................................................... [ 50%]tests/test_debug.py . [ 50%]tests/test_rand.py .... [ 51%]tests/test_ssl.py ...................................................... [ 61%]........................................................................ [ 76%]........................................................................ [ 90%]............................................... [ 99%]tests/test_util.py . [100%] =============================== warnings summary ===============================tests/test_crypto.py:21 /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_crypto.py:21: DeprecationWarning: sign() is deprecated. Use the equivalent APIs in cryptography. from OpenSSL.crypto import ( tests/test_crypto.py:21 /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_crypto.py:21: DeprecationWarning: verify() is deprecated. Use the equivalent APIs in cryptography. from OpenSSL.crypto import ( tests/test_ssl.py::TestContext::test_set_cipher_list[hello world:AES128-SHA1] /home/tkloczko/rpmbuild/BUILD/pyopenssl-24.1.0/tests/test_ssl.py:499: DeprecationWarning: str for cipher_list is no longer accepted, use bytes context.set_cipher_list(cipher_string) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html======================= 504 passed, 3 warnings in 7.45s ======================== — Reply to this email directly, view it on GitHub <#1298 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBGSGSSN2CC3OEK3XDDYYGZYLAVCNFSM6AAAAABEV5WRF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXGYZDMNRQGI> . You are receiving this because you commented.Message ID: ***@***.***>

[kloczek]

Yes, those warnings are expected at this time

Thank you very much for your time 👍 😄
Closing

PS. Would you accept PR with filtering all pyopenssl code over pyupgrade --py38 and bumping minimum python version to 3.8 ?🤔
(3.7 has been EOSed +halt year ago)

[kloczek]

No, we won't drop 37 until our users stop using it.

OK 👍