Giter Site home page Giter Site logo

Comments (6)

richardotis avatar richardotis commented on June 13, 2024

I also looked into if it would be possible to get rid of pycalphad/tests/datasets.py and just ship the original TDB files directly as pkg_resources, but it actually looks pretty nasty to get access to the TDBs at run-time and keep .egg compatibility (since you can't always assume your module files are separate files on disk):
http://peak.telecommunity.com/DevCenter/PythonEggs#accessing-package-resources
Accessing package data via ResourceManager API (for setuptools): http://peak.telecommunity.com/DevCenter/PkgResources#resourcemanager-api

from pycalphad.

bocklund avatar bocklund commented on June 13, 2024

As an alternative to shipping the tests, we can easily let pycalphad developers get the required packages for testing and benchmarking with a requirements.txt file. That way the testing and benchmarking can not be installed by users through PyPI/conda-forge.

We discussed (and this issue until now has considered) shipping tests to be able to validate user installations if there are any issues, but I think this will become less important as pycalphad continues to become more stable.

An example requirements.txt file would contain just asv, nose, coverage, ..., while the dependencies for pycalphad (numpy, dask, ...) should continue to live in setup.py

from pycalphad.

bocklund avatar bocklund commented on June 13, 2024

If we really wanted to do this so people who did not install in develop mode can run the test suite, I don't think that's relevant. The test suite should always pass for releases on all systems.

from pycalphad.

richardotis avatar richardotis commented on June 13, 2024

Given that we're taking benchmarking in a different direction and we already do automated testing on most configurations, I do not think it's worth complicating our build/release process to make this work as an optional add-on.

from pycalphad.

bocklund avatar bocklund commented on June 13, 2024

Closing this and putting a task to drop asv on the roadmap.

from pycalphad.

amjokisaari avatar amjokisaari commented on June 13, 2024

regarding adding tests, my motivation for this is to verify my python environment / PATH to needed tools (e.g., as found with my running the examples...).

from pycalphad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.