More optimized plugin integration, avoid replacing all text.

[pycqa]

More optimized plugin integration, avoid replacing all text.

[thijsdezoete]

This is only possible if you're not running the thing after just opening a file, what is the extra value by doing this(other than saving a few cpu cycles)?

[timothycrosley]

This is really specific to the kate plugin, as I was informed by another kate plugin writer that replacing all text can lead to worse then expected performance degredation. Even so i may not implement it as it seems to me something that should be optimized in kate itself

[thijsdezoete]

Ah, ok.. Perhaps something to share with the kate development team. :)

[timothycrosley]

Agreed changing this to wontfix and will notify them :)

[zaufi]

there is nothing to notify about...

[timothycrosley]

@zaufi does your old comment about Kate having to reparse, highlight, setup undo action, & etc no longer apply? I suppose an undo action is actually the desired behavior (as if something happens undesired when sorting I do want the user to be able to undo it). However, when initially writing the plugin I assumed Kate was smart enough to not re-parse / repaint everything if only a small portion of the file had changed (ie it shouldn't be faster to diff the changes that smartly reinsert - then just for me to reinsert the text) but your comment made me believe otherwise? Did I misunderstand the issue?

[zaufi]

@timothycrosley yes, it is -- if u r going to setText() kate will do a lot of work... but there is no other way to do so: if u tell to a KTextEditor::Document to replace whole text w/ smth else, kate do not care about what it contains before... it just clear() internal buffer (setting undo action, and remembering line marks) and do everything from the beginning (starting from lines split and finishing w/ restoring marks). Thanx to fast CPUs we have nowadays it happens fast enough, but resetting whole document is a bad practise anyway.
And I bet nobody in the kate team will take care about "what if 99% of the reinserted text is the same as it was before" and handle this case... Kate's internals are complicated enough already even w/o this "feature"... and kate team work hard to make it faster (for example having too much RegExps in a syntax file also considered as a bad practise :) -- not talking about resetting a whole document... so it is a matter of plugin writer to make it as fast as he can... If u can't -- don't worry. Just hope users w/ fast CPUs will notice nothing ;-)