Giter Site home page Giter Site logo

isort misplaces django.utils.six about isort HOT 6 CLOSED

pycqa avatar pycqa commented on May 30, 2024
isort misplaces django.utils.six

from isort.

Comments (6)

timothycrosley avatar timothycrosley commented on May 30, 2024

Thanks for reporting! This issue has been verified and will be fixed before the next release

from isort.

timothycrosley avatar timothycrosley commented on May 30, 2024

Thanks again for alerting me to this issue! It has been resolved in the latest release (2.2.0) and lead to general improvements to the detection of import sections.

from isort.

graingert avatar graingert commented on May 30, 2024

have you added test cases for this?

from isort.

timothycrosley avatar timothycrosley commented on May 30, 2024

No, as it's a heard thing to reliably test (it depends on the local environment, If I don't have Django installed the test will fail incorrectly). Is the functionality still not working as expected on your local installation?

from isort.

graingert avatar graingert commented on May 30, 2024

you can build a custom test environment with http://travis-ci.org/

This project seems like it would be quite easy to write test cases for: just a bunch of python files and their expected isort order

from isort.

timothycrosley avatar timothycrosley commented on May 30, 2024

Thanks for the suggestion, will investigate it further. It is indeed pretty easy to write test cases for it: https://github.com/timothycrosley/isort/blob/develop/test_isort.py, However none of them fully test the module placement support so I think extending that via a specified test environment would be useful.

from isort.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.