Comments (6)
Thanks for reporting! This issue has been verified and will be fixed before the next release
from isort.
Thanks again for alerting me to this issue! It has been resolved in the latest release (2.2.0) and lead to general improvements to the detection of import sections.
from isort.
have you added test cases for this?
from isort.
No, as it's a heard thing to reliably test (it depends on the local environment, If I don't have Django installed the test will fail incorrectly). Is the functionality still not working as expected on your local installation?
from isort.
you can build a custom test environment with http://travis-ci.org/
This project seems like it would be quite easy to write test cases for: just a bunch of python files and their expected isort order
from isort.
Thanks for the suggestion, will investigate it further. It is indeed pretty easy to write test cases for it: https://github.com/timothycrosley/isort/blob/develop/test_isort.py, However none of them fully test the module placement support so I think extending that via a specified test environment would be useful.
from isort.
Related Issues (20)
- Black line length config support when using `--profile black`? HOT 1
- isort does not recognize _collections_abc as part of the standard library HOT 1
- Unrecoverable exception thrown using --sort-reexports
- Feature Request: Automatic Conversion of Relative Imports to Absolute Imports
- isort doesn't format the imports in PyCharm's Jupyter notebooks
- False order of local imports relative to standard library imports
- Circular Import Issue Due to Import Reordering in Python 3.8
- Bug : isort add empty lines before pylint comments
- Deprecate `setuptools` integration comand
- Docs: GitHub action and Pre-commit need better configuration/args examples HOT 1
- Bug: Word wrapping works incorrectly with force_single_line=True
- isort breaks the code with sort_reexports = true HOT 2
- noqa isn't well respected
- Feature request: per-block sorting strategy (inline sort)
- Isort does not honor skip directories
- `isort` does not move all imports to the top of the file when there are imports after other code blocks
- `--sort-reexports` does not respect `--profile=black` HOT 2
- isort --profile black produces long lines HOT 8
- isort copies comments across imports HOT 4
- Feature request: Remove superfluous `import a` statements when there is already `import a.b`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isort.