Giter Site home page Giter Site logo

Comments (2)

asottile avatar asottile commented on May 26, 2024

this passes, though I'm not sure it's right -- I'm inclined to just say "you're doing too much in an f-string and the linter is rightfully punishing you" (despite the probable bug) -- do the assignments to some variables outside the fstring and the code will be much easier to read and maintain anyway:

class T:
    def m1(self):
        print(f"""
preamble
{some_long_func(
            some_long_arg, other_long_arg, more_long_arg)}
postamble
""")

    def m2(self):
        print(f"""
preamble
{some_long_func(
            some_long_arg, other_long_arg, more_long_arg)}
postamble
""")

from pycodestyle.

anntzer avatar anntzer commented on May 26, 2024

Ah, I didn't think of trying to indent all the way up to the indent defined by outside the f-string.
I would still say it is a bug (I think the reasonable indent would be 4 (or 5) spaces from the left, i.e. including the opening brace or not, but I leave it up to you as to whether this is something you want to fix or just to close.
Alternatively, another solution would be to just accept all indents inside a multiline f-string, because I don't think there's actually any clear style guidelines about that (well, possibly except "don't have substitutions so long that they must be split over multiple lines"... which could possibly be its own style check).

from pycodestyle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.