Entry point missing

[pycqa]

Entry point missing

[keleshev]

Right now pep257 has the following Python API: https://github.com/GreenSteam/pep257#python-api

Or what kind of entry point do you mean?

[sandreanybox]

Hum, i don't say if it's better. I would like like mccabe. For symbole référence, i think C95 is ok, but not sure. I ask here flake8 issue

[keleshev]

Sorry, I don't understand you; could you clarify?

[JensRantil]

@halst wrote:

Sorry, I don't understand you; could you clarify?

After reading @sandreanybox's comments a couple of times and checking out the entry_points for mccabe, I just figured it out :-) @sandreanybox would like us to add similar entry points to pep257 since that's how flake8 picks up its plugins. It seems like this is in line with the effort discussed in the code-quality thread.

While there is an API, I have nothing against adding an entry_point in setup.py, too. @halst, do you? That said, it's not just for us to add an entry point. That entry point also need to support a common format that flake8 can understand. That's where the mailing list discussion comes in, I guess.

[sandreanybox]

Excuse me for my lack of clarity !
But i want to use your wonderful pep checker in flake8. For this purpose I need setuptools, particular log format, and a class for entry point. I have made my own branch here,And i will prevent you when my work will be functional.
thanks a lot
I you have work about this say to me.

[JensRantil]

@sandreanybox As @halst pointed out, you can use our API as a workaround.

[sandreanybox]

work in progress,
https://github.com/sandreanybox/pep257/blob/master/pep257.py#L707
But I'm not sure to be in a good way !
work in progress...

[JensRantil]

@sandreanybox Could you brief me, what does C95 refer to?

[sigmavirus24]

@sandreanybox you're taking the wrong approach to this. Check out how PyFlakes works with Flake8. I'm somewhat certain that pep257 support can be added in a similar way to how flake8/_pyflakes.py works, just not by including it in the source of flake8. (Although I wouldn't be against default inclusion probably).

@JensRantil, C95 is the error code prefix for McCabe complexity errors, i.e., an error will be identified like so: C95x. We do the same for PyFlakes errors as well in the file I mentioned above.

I'm fairly certain we could wrap your API without significant (or ideally any) changes to pep257. I haven't had the chance to look into it myself though.

[JensRantil]

@sigmavirus24 I see. Thanks for taking the time to explain this!

[sandreanybox]

@sigmavirus24
Hey,
I took more time for inspect all related flake8 module.
pep8 use ast class checker, and logical line / physical line function checker
pyflakes have an AST class checker
Mccabe also

I have made an class like ast checker, and I parse all file with check_source.
I can't do better without refactoring.
For flake8 extension code i use for test purpose G20
And I've add some code error to all check function.
I can add options.select error code. But i need check before proceeding.
maybe I'm totally in the wrong way :(
My branch is here

Thanks

[sigmavirus24]

@sandreanybox you're definitely doing far more work than is necessary and most likely on the completely wrong track. Let's close this issue and communicate elsewhere. This isn't a bug or such with pep257. Thanks

[sandreanybox]

Ok, I close it.
Thanks a lots everybody for take care of my problem...