What will happen to things that got removed ?

[pydantic]

What will happen to things that got removed ?

[Kludex]

Got an idea!

I'm going to do the transformation, and add a TODO note.

This:

class Foo(BaseModel):
   class Config:
         getter_dict = SomeClass  # getter_dict is no longer present in pydantic v2

To:

class Foo(BaseModel):
   # TODO: The `getter_dict` was removed, please check LINK.
   model_config = ConfigDict(getter_dict=SomeClass)

[Kludex]

We have some options for that specific case. Let's see which one is the best:

1. Don't check removed attributes from Config. Runtime will fail.
2. Don't refactor that class, and raise a warning.
3. Refactor that class, and raise a warning.

Unless I'm forgetting something, those should be the available options.

Option 1 I think is out of question, but it's what is currently implemented, since there's no logic to verify removed fields.

As for 2, and 3, I guess 3 would be easier for the user, because 2 implies the user will have to do all manual changes.

[lig]

Adding a TODO seems like a nice touch

[Kludex]

The decision here:

1. Only Config classes with assignments are converted to model_config. If there's any other structure like functions, or classes inside, then a note is added mentioning that the user should manually replace it (with a link to the migration docs).
2. If the keyword got removed, a specific note is added, informing about the removal. In this case, the model_config replaces the Config.

I'll close this because I think I've addressed the question, but feedbacks are welcome.