Giter Site home page Giter Site logo

Comments (8)

tiran avatar tiran commented on September 16, 2024 1

Rust 1.73 is missing some features. MSRV can be lowered to 1.75, but not below. See #1315

from pydantic-core.

davidhewitt avatar davidhewitt commented on September 16, 2024 1

I think 1.73 would still be reachable but it'd be a lot more work.

from pydantic-core.

davidhewitt avatar davidhewitt commented on September 16, 2024

The hint here is already in your build output:

(/private/var/folders/_n/8qwtj23j0tx0bdy7ftvpg63m0000gn/T/pip-install-a3iwsm3w/pydantic-core_1e29f10ace204ee99125b93a432e3171)` cannot be built because it requires rustc 1.76 or newer, while the currently active rustc version is 1.72.1

If you update your Rust compiler (probably with rustup update) and retry, it should work.

from pydantic-core.

BLKSerene avatar BLKSerene commented on September 16, 2024

@davidhewitt Unfortunately, starting from Rust 1.74, the minimum supported macOS platform is macOS 10.12 (see here), so the latest Rust compiler supporting OS X 10.11 is Rust 1.73. I tried installing the latest Rust using the standalone installer, but that did not work.

If pydantic chooses to drop support for macOS < 10.12 (Python 3 still supports far back to macOS 10.9), it would be better to explicitly state that in the doc.

from pydantic-core.

davidhewitt avatar davidhewitt commented on September 16, 2024

That's a great point. I think we should consider downgrading our minimum Rust to 1.73, but this may not be trivial.

from pydantic-core.

davidhewitt avatar davidhewitt commented on September 16, 2024

^ reflecting on the above, I think downgrading is the right thing, but I think the reality is that extending support backwards to old macOS versions is not a high priority for me right now. If anyone is interested in helping downgrade, a PR is very welcome.

from pydantic-core.

BLKSerene avatar BLKSerene commented on September 16, 2024

Could you please give some hints about how to contribute on this specific downgrading issue?

from pydantic-core.

davidhewitt avatar davidhewitt commented on September 16, 2024

The idea would be that you can check the compile against Rust 1.73 (for example) by running cargo +1.73 check in this directory.

Or you could set the rust-version in Cargo.toml to 1.73 and push a PR, which will run the checks on the pipeline here.

I expect that there are a couple of language features and stdlib APIs which we use which will need replacing. If it's not clear how to replace them, perhaps post back here with examples and I can give suggestions.

from pydantic-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.