Comments (30)
it's open. A related merge request is there so I suggest that you take a look at that and see what discussion happened there.
I reviewed #74 and except 1 change everything seems to be fine. I don't understand why it is not changed and merged till now.
from pyjudge.
I would like to contribute if possible
from pyjudge.
from pyjudge.
Yea I am pretty new to contribution and this is for a university project. So far I've forked and cloned the project. Is there anything else I should know? Should i submit changes to the master branch or another other branch?
from pyjudge.
from pyjudge.
Alright
from pyjudge.
The html in
index.html
has some CSS classes which are note being used. We need to clean it up. that file also has lots of inline style code. That has to be removed.
@theSage21 all the inline style code is to be removed ..is it?? There are 5 places where the inline style is used in index.html!!!
from pyjudge.
from pyjudge.
Can i take the issue and work on it ?
from pyjudge.
sure @Priyanka-ashok. feel free to ask here if you have any doubt. you can also join the telegram group mentioned in README.md for general purpose.
from pyjudge.
Is this issue resolved or something is needed to be done?
from pyjudge.
it's open. A related merge request is there so I suggest that you take a look at that and see what discussion happened there.
from pyjudge.
from pyjudge.
Would it be okay to merge both css files so it's just one css with everything?
from pyjudge.
from pyjudge.
Definitely! But only if the CSS is used in both html files. Otherwise just move the common content to one file and keep the unique content in a style tag
…
On Tue 19 Feb, 2019, 01:10 Matthew @.*** wrote: Would it be okay to merge both css files so it's just one css with everything? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVj0dqBcjwOcUpLWz39wvZ9GDngQcGUks5vOwGTgaJpZM4aUuA_ .
Maybe we can use html and css which is common in all html and css files in 1 base.html template using inline styling or do we need to do it in 2 different template files 1 for html and 1 for css?
from pyjudge.
That is a matter of taste. I usually put it in a separate file so that other people can work on CSS separately and the PRs don't create merge conflicts.
from pyjudge.
Well I'm a CS student and I feel that would be better for organization. I'll merge the css files, obviously the unique stuff for each html file will work as well, I will make that work, don't worry. In the end, having a clean HTML file is good and a CSS file to control all the looks.
from pyjudge.
Sure! Go ahead!
from pyjudge.
In index.html there is an anchor to the "here" that is href="#"
from pyjudge.
Are you referring to this line?
That is a placeholder. When we have something we will put it there. At least that's what it looks like.
A better person to ask would be the person who wrote that. From the Blame window it looks like @rustagishubhi is the one who can answer that
from pyjudge.
@adityabohra007 you can replace the # with the link where the criterias are mentioned
from pyjudge.
Hi,
Can I contribute to this project? Is there any other issues related to HTML and CSS. I am happy to work on them.
Please let me know.
Thanks
from pyjudge.
from pyjudge.
Hi,
@theSage21
When I click on the link. I get this error.
"Whoops! That unsubscribe link isn't valid for your account."
Thanks
from pyjudge.
from pyjudge.
oh now it makes sense. you wanted some other HTML stuff.
#62 #30 and #59 are all related to HTML CSS
from pyjudge.
Is there any other html/css related stuff I could work on?
from pyjudge.
you mean besides the issues that are already open?
from pyjudge.
Yeah
from pyjudge.
Related Issues (20)
- Database HOT 1
- Contest timings HOT 2
- Home page HOT 5
- Multiple contests
- Multiple contest UI design
- Move pre-commit and black to dev dependencies
- Pip installable project HOT 11
- 404 handler HOT 2
- Proper question statement and support HOT 5
- Session support
- Use sqlite as a database
- Interface to add questions via website HOT 4
- Raise error in proper places HOT 5
- Use a more common template system HOT 5
- Continuous testing needs to be added
- User stats/ profile HOT 4
- problem status in contest
- Reinstall black HOT 1
- Code Documentaion HOT 1
- Install pytest in pipenv HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyjudge.