_get_cache_key is concatening non utf-8 encoded objects

[pylast]

_get_cache_key is concatening non utf-8 encoded objects

[hugovk]

From [email protected] on March 28, 2009 13:26:31

this should be fixed by now as well.

Status: Fixed

[hugovk]

From nichte on May 13, 2009 05:57:08

I still have this issue in 0.3.4

Also the same thing applies to _Request._download_response(self) where quote_plus is
also called without escaping the parameters first.

[hugovk]

From [email protected] on May 13, 2009 06:02:15

Can you elaborate on how to reproduce the error?

[hugovk]

From nichte on May 13, 2009 06:28:20

Sorry :)

It's basically the same as what sabailiez mentioned:

When I try to download data for anything that has unicode characters I get:

File "D:\projects\mainstream_meter\pylast.py" in _download_response

1.      data.append('='.join((name, urllib.quote_plus(self.params[name]))))
   

   File "C:\Python25\lib\urllib.py" in quote_plus

2.     s = quote(s, safe + ' ')
   

   File "C:\Python25\lib\urllib.py" in quote

3. res = map(safe_map.**getitem**, s)
   

Exception Type: KeyError at /user/Luthya/12month/
Exception Value: u'\xe9'

It works after changing line 224 to:
data.append('='.join((name, urllib.quote_plus(self.params[name].encode('utf-8')))))