Comments (9)
Hi @kenteross! Thanks for opening this issue! As the code is long and has text, can you share it in a GitHub gist or a Google Colab notebook, please 🙏 ?
from pymc-marketing.
@wd60622 thanks for your suggestions! I tried reducing the l_max and importing the packages independently and it seems like the issue was coming from the l_max. It seems like the maximum threshold for an l_max is around 20 in this case. I'll stick with weekly data for now. Thanks for the help!
from pymc-marketing.
@wd60622, yeah, that makes sense to model weekly data and reduce l_max so much. Thanks for the tips!
from pymc-marketing.
Hi @juanitorduz! Thanks for the quick reply! Sorry, I didn't realize it was in text format. Here's a GitHub gist of my code!
from pymc-marketing.
Hi @kenteross , I see that that the l_max is 50
Have you tried a smaller value? Does it cause issues with l_max = 5 or 10?
Weekly datasets tend to be common so 50 days = l_max of 7
from pymc-marketing.
Are you also able to import the function from the package as well instead of copy and paste. I see the functions have changed and maybe there has been a bug fix. Module for reference
from pymc_marketing.mmm.transformers import delayed_adstock, geometric_adstock, logistic_saturation
from pymc-marketing.
@wd60622 thanks for your suggestions! I tried reducing the l_max and importing the packages independently and it seems like the issue was coming from the l_max. It seems like the maximum threshold for an l_max is around 20 in this case. I'll stick with weekly data for now. Thanks for the help!
Glad that it helped.
And just to be clear, did the model start sampling? (progress bar, etc)?
And it only successful with which ordering?
- adstock -> saturation
- saturation -> adstock
If you just perform the adstock, does the large l_max cause issues?
from pymc-marketing.
Yeah, thanks!
The model did start sampling even when it ran into an issue. It would just run my machine out of RAM, almost like it was caught in a loop.
When I reduce the l_max it's successful in either order, but with a large l_max it's only successful in the adstock -> saturation order.
If I remember correctly just performing adstock with a large l_max would result in an issue. I can test it again tomorrow if you like.
from pymc-marketing.
If I remember correctly just performing adstock with a large l_max would result in an issue. I can test it again tomorrow if you like.
All good! Thank you for summarizing your findings!
My only suggestion is to model weekly data in order to reduce the l_max
by factor of 7. Maybe @juanitorduz has some additional tips?
from pymc-marketing.
Related Issues (20)
- Hierarchical distributions for all parameters in model config HOT 4
- Notebook for custom models
- Different media transformations across different channels HOT 3
- Create `numpydoc_xref_alias` for docstring aliases
- Does pymc-marketing mmm library scale control columns? HOT 1
- test against actual mmm fit results
- Media transforms prior sampling & curve plotting HOT 1
- Default priors for saturation and adstock functions HOT 1
- Causality notebooks & Structural PyMC-Marketing equations HOT 2
- Prepare for PyMC 5.16 release HOT 1
- Fix `ParetoNBDModel` Docstring Typos HOT 2
- Expose minimization kwargs in budget optimization
- Separate Weibull CDF and PDF classes
- Expected the # of transactions & CLV etc HOT 5
- Explicit dims in model config
- MMM tests depend on order of run
- Consolidate `ModelBuilder` InferenceData getters (and setters)
- Consider changing logo green color to redish-orange? HOT 8
- mark tests as slow
- Wrapper `Prior` / `Distribution` class HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymc-marketing.