Improve error message for missing rust compiler

[pyo3]

Improve error message for missing rust compiler

[alex]

First, thanks!

I think there's two basic issues we're seeing:

a) The missing rust compiler case -- I think pointing folks to rustup would likely help some of them. This one is pretty easy for us to document though.

b) Older rusts which are less than the MSRV for pyo3. There's an in-progress cargo support for specifying MSRV, which would solve this. I was thinking about possibly proposing a setuptools-rust-level MSRV -- have it check the version before building and clearly error in that case. Dunno if y'all would want that feature, knowing that it'll be obviated by upstream adding it not too far down the line.

[davidhewitt]

I'd be in favour of having (b) - I think the nicer we can make support for the Python ecosystem now, the better. We can gradually deprecate the support out of setuptools-rust once upstream cargo has it.

[alex]

Actually... I think setuptools-rust already supports this: https://github.com/PyO3/setuptools-rust/blob/991de4cc5423d4187ffd16ef185b7db10b4cb06c/setuptools_rust/extension.py#L24 ?

…

On Mon, Feb 8, 2021 at 6:17 PM David Hewitt ***@***.***> wrote: I'd be in favour of having (b) - I think the nicer we can make support for the Python ecosystem now, the better. We can gradually deprecate the support out of setuptools-rust once upstream cargo has it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBCUEYATO5QFYKQP6LLS6BWIJANCNFSM4XJ4XYSQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[davidhewitt]

Aha yes, though it's clearly not well documented 😅

[alex]

Well, we now shipped a release using that, so I guess it works well enough :-)

[davidhewitt]

Merged #117 to make a couple of improvements on our end.