Specify --target automatically based on which python is in use?

[pyo3]

Specify --target automatically based on which python is in use?

[davidhewitt]

Ouch. Technically what you're doing is a form of cross-compile, so whatever solution you propose should probably be compatible with #10.

I'm tempted to punt and say that this is a misconfiguration of your build environment; not something that setuptools-rust can elegantly handle. But if you think a windows-specific fix can be written that's easy and reliable, I could be persuaded to accept a patch.

[alex]

I think there's probably a narrow fix, yes. I agree it's technically cross-compilation, however as a practical matter this is how lots of Windows building is done :-/ https://github.com/pyca/cryptography/pull/5357/checks?check_run_id=954276072 is an example failure ATM.

[davidhewitt]

Ah, I see; I slightly misunderstood what you meant - you want to compile a 32-bit package with a 32-bit Python! (I'd thought you meant you wanted to compile a 64-bit package from the 32-bit python.)

I'm going to u-turn and say that it's totally applicable for setuptools-rust to attempt to detect and set --target here. I think really it would be a good measure if it did this on all platforms, because otherwise other environment such as rustup default target can also cause trouble.

I'm happy if you just want to provide an implementation for windows for now, with a TODO in the code that points to this issue saying other platforms could have this added too.

[alex]

Sounds good!

…

On Thu, Aug 6, 2020 at 12:15 PM David Hewitt ***@***.***> wrote: Ah, I see; I slightly misunderstood what you meant - you want to compile a 32-bit package with a 32-bit Python! (I'd thought you meant you wanted to compile a 64-bit package from the 32-bit python.) I'm going to u-turn and say that it's totally applicable for setuptools-rust to attempt to detect and set --target here. I think really it would be a good measure if it did this on all platforms, because otherwise other environment such as rustup default target can also cause trouble. I'm happy if you just want to provide an implementation for windows for now, with a TODO in the code that points to this issue saying other platforms could have this added too. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBDVKRW257QIZIJDQKDR7LJKTANCNFSM4PWWW4JA> .

-- All that is necessary for evil to succeed is for good people to do nothing.