Giter Site home page Giter Site logo

Rename Pipfile to Pipfile.toml about pipfile HOT 12 CLOSED

pypa avatar pypa commented on July 29, 2024 7
Rename Pipfile to Pipfile.toml

from pipfile.

Comments (12)

thekashifmalik avatar thekashifmalik commented on July 29, 2024 13

Fine I'll bite:

Makefile: makes sense since it's a custom format.
Dockerfile: makes sense since it's a custom format.
Pipfile: silly because it's perfectly valid TOML.

Now we need to tell vim that Pipfile's are TOML.

Where did you guys disqus this BTW? I'll join for future reference.

from pipfile.

dstufft avatar dstufft commented on July 29, 2024 10

The *file convention has existed since the 70s, software that can't cope with it is broken.

from pipfile.

thekashifmalik avatar thekashifmalik commented on July 29, 2024 9

Wish I had taken part in this discussion when it was going on. Would have really pushed for the very simple pip.toml. Damn docker making everyone adopt the *file convention.

:(

from pipfile.

 avatar commented on July 29, 2024 6

this is more relevant now that pyproject.toml exists,
folks over at rustlang have Cargo.toml and Cargo.lock
consistency ftw

from pipfile.

akatrevorjay avatar akatrevorjay commented on July 29, 2024 5

@dstufft It's obviously not about software cope, but human cope.

from pipfile.

janhohenheim avatar janhohenheim commented on July 29, 2024 5

@kennethreitz Would you consider your stance on this based on the comments in the issue?
Personally, I would like to hear your thoughts on this, as I'm sure you have valid reasons for this decision. However, as it stands, I fail to see any compelling argument for dropping the .toml ending.

from pipfile.

Sajjon avatar Sajjon commented on July 29, 2024 3

I too find it very unfortunate that Pipfile (toml), Gemfile, (ruby) Podfile (ruby) does not use the correct file extension, now ALL developers around the world have to tell their texteditor to use the correct syntax highlighting every time every developer open said files. Sure it takes just around one second in Sublime Text (CMD+SHIFT+P SS toml/ruby), but still, whyyyyyy?!

from pipfile.

akatrevorjay avatar akatrevorjay commented on July 29, 2024 2

I wish I had taken part in this too; I personally really dislike these redundant idioms that thrive among software I see and use every day. It's rather redundant to suffix your files with "file" to be honest; but that I can totally live with pipfile.toml so every engineer in the world that reads it doesn't have to edit their configuration to accommodate it. It also separates the format from the purpose. It's good practice.

It's not even Pythonic requiring a capital letter. :(

from pipfile.

kennethreitz avatar kennethreitz commented on July 29, 2024

we had a long discussion about filenames already, and determined these filenames are best.

from pipfile.

phrohdoh avatar phrohdoh commented on July 29, 2024

@kennethreitz In that case suggesting this be opened here wasn't a good use of anyone's time.

from pipfile.

kennethreitz avatar kennethreitz commented on July 29, 2024

Well, other people may want to comment.

from pipfile.

tony avatar tony commented on July 29, 2024

vim users:

If you use vim-plug:

Plug 'cespare/vim-toml'  " Support for highlighting toml filetype

if executable('pipenv')
  au BufNewFile,BufRead Pipfile     setf toml
endif

If you already have toml highlighting from a plugin (agnostic of using vim plug) and want Pipfile to be detected as toml:

au BufNewFile,BufRead Pipfile     setf toml

You can also add support for Pipfile.lock:

au BufNewFile,BufRead Pipfile.lock     setf json 

from pipfile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.