Add @huxuan as maintainer

[dukecat0]

Add @huxuan as maintainer

[huxuan]

Thanks everyone for the recognition. Wish more cooperation with you guys and more contribution to pipx, PyPA and Python community.

[chrysle]

I'm on board!

[uranusjr]

Sounds good to me

[gaborbernat]

+1

…

On Tue, Apr 30, 2024, 07:32 Tzu-ping Chung ***@***.***> wrote: Sounds good to me — Reply to this email directly, view it on GitHub <#1385 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFIQPXUJRU3QG35KCQLIADY76TPJAVCNFSM6AAAAABHAHPVR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVGQ4TKMZQGQ> . You are receiving this because you are on a team that was mentioned.Message ID: ***@***.***>

[henryiii]

+1

[pfmoore]

I'll ask the pypa owners what we should do about this - needing an organisation owner to invite anyone who needs to become a maintainer on any PyPA project doesn't really seem to fit with our policy of projects being self-governing. And if it is necessary, we should have a better way for projects to request an owner send out the invite, rather than trying to find individuals who might be able to help...

Also, I'll be honest, I don't know the implications of inviting someone to be a member of the PyPA github org. Given the recent xz issue, I'm not comfortable with the risk of accidentally giving people too much access, simply because of how we've structured the organisation.

Give me a while to check with people, but I can send an invite to @huxuan once we've worked out the policy implications...

[pfmoore]

OK, we've discussed this and pinging the admins to get an invite sent seems fine - no need for any additional bureaucracy.

I've sent an invite to @huxuan. And for future issues like this, we now have a @pypa/owners group that will ping all of the PyPA admins.

[huxuan]

I just found I can request to join and @uranusjr approved that very quickly. So we are done. Thanks again!

[gaborbernat]

@pfmoore can you make it happen?

[pfmoore]

@gaborbernat Is this not something the pipx team can do themselves? I'd expect the pipx admins to be able to do this (I'm not a maintainer on pipx, much less an admin). If the team can't do this themselves, I'd rather work out why and fix that, rather than having you rely on me to add new maintainers.

[gaborbernat]

@gaborbernat Is this not something the pipx team can do themselves? I'd expect the pipx admins to be able to do this (I'm not a maintainer on pipx, much less an admin). If the team can't do this themselves, I'd rather work out why and fix that, rather than having you rely on me to add new maintainers.

I try to do this, but seemed that I can only add collaborators who are already member of the organization. There are definitely some permissions missing for us to do this.

[pfmoore]

OK, can we find out what's missing? I'm reluctant to lose the opportunity to work out how to properly fix this while we have a test case to hand (IIRC, I added a previous maintainer here, so this has been a problem for some time and it should get fixed properly - relying on me isn't sustainable in the long run).

[chrysle]

According to this and this, someone should be granted the admin role for this repository. @cs01 should already be an admin and be able to do that.

[pfmoore]

From what I can see, all pipx committers have the admin role:

There are 8 people in that team, including @gaborbernat and yourself:

I don't see why that doesn't give you the right to manage the project directly 🙁

[dukecat0]

I think before we can add someone to the team, they need to be invited to join the pypa organization first.

[chrysle]

I think before we can add someone to the team, they need to be invited to join the pypa organization first.

Hmm, how did you get to this page?

[dukecat0]

https://github.com/orgs/pypa/teams/pipx-team, though this one isn't for the commit access.

[pfmoore]

That rings a bell. You can invite someone to the pypa org from https://github.com/orgs/pypa/people - can anyone here do that, or does it need some special privilege that we need to sort out?

[chrysle]

I think only organization owners can do that.

[pfmoore]

Hmm, that seems limiting:

[chrysle]

Looks like there is nothing else to do here.

[dukecat0]

I think he still needs to be added to @pypa/pipx-committers.

[chrysle]

@dukecat0 Could you do that?