Giter Site home page Giter Site logo

Comments (5)

nicoddemus avatar nicoddemus commented on August 23, 2024

linting is not testing, and we should stop pretending and also add linting/metrics to the GitHub integrations

What do you mean?

from pluggy.

RonnyPfannschmidt avatar RonnyPfannschmidt commented on August 23, 2024

atm flake8 issues show up as test failures on travis, thats simply wrong on many levels

from pluggy.

nicoddemus avatar nicoddemus commented on August 23, 2024

atm flake8 issues show up as test failures on travis, thats simply wrong on many levels

Why do you say that's wrong, would you care to elaborate? 😁

from pluggy.

RonnyPfannschmidt avatar RonnyPfannschmidt commented on August 23, 2024

i consider style issues and code smells distinct from actually broken real tests

from pluggy.

hpk42 avatar hpk42 commented on August 23, 2024

sure a style failure is different from a functional test failure but then again we simply have a set of automated tests that we want to keep passing ideally for each commit. I am fine with a PR which puts linting to tox instead of to pytest runs proper, however. Feel free to do a PR on pluggy if you'd like to see it there, it's not a real bug or feature but just a little refactoring in my book that we may or may not do.

from pluggy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.