Comments (5)
linting is not testing, and we should stop pretending and also add linting/metrics to the GitHub integrations
What do you mean?
from pluggy.
atm flake8 issues show up as test failures on travis, thats simply wrong on many levels
from pluggy.
atm flake8 issues show up as test failures on travis, thats simply wrong on many levels
Why do you say that's wrong, would you care to elaborate? 😁
from pluggy.
i consider style issues and code smells distinct from actually broken real tests
from pluggy.
sure a style failure is different from a functional test failure but then again we simply have a set of automated tests that we want to keep passing ideally for each commit. I am fine with a PR which puts linting to tox instead of to pytest runs proper, however. Feel free to do a PR on pluggy if you'd like to see it there, it's not a real bug or feature but just a little refactoring in my book that we may or may not do.
from pluggy.
Related Issues (20)
- Feature Suggestion: Collect multiple exceptions from hook implementations HOT 10
- Patterns to enable and disable plugins? HOT 9
- Avoid erroring from tracing HOT 4
- Drop Python 3.7
- Export our typing HOT 2
- multi hook registration does not unregister HOT 6
- Can plugins be executed concurrently? HOT 3
- RFE: is it possible to start making github releases?🤔 HOT 3
- pytest won't run root conftest.py's pytest_configure in special circumstances HOT 2
- Rename misleading function name `PluggyManager.load_setuptools_entrypoints` HOT 3
- Issue with ordering of hooks HOT 2
- Question about default values in hook implementation HOT 1
- discussion: pluggy speedup by using 'codegen' HOT 7
- Is it possible to override an existing hook with a HookCaller class?
- pluggy loads disabled pytest plugins HOT 5
- Warn when old-style hookwrapper raises during teardown
- Add python-lsp-server to downstream tests
- Troubles to understand the new updates on Pluggy HOT 11
- Bug: Pluggy 1.4 searches all home dirs for __init__.py HOT 2
- Possible to tell which hook answered a call? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pluggy.